Skip to content

Commit e556f6b

Browse files
Christoph Hellwigaxboe
authored andcommitted
block: remove the bd_queue field from struct block_device
Just use bd_disk->queue instead. Reviewed-by: Johannes Thumshirn <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
1 parent 6b7b181 commit e556f6b

File tree

8 files changed

+11
-15
lines changed

8 files changed

+11
-15
lines changed

drivers/dax/super.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ EXPORT_SYMBOL(bdev_dax_pgoff);
5959
#if IS_ENABLED(CONFIG_FS_DAX)
6060
struct dax_device *fs_dax_get_by_bdev(struct block_device *bdev)
6161
{
62-
if (!blk_queue_dax(bdev->bd_queue))
62+
if (!blk_queue_dax(bdev->bd_disk->queue))
6363
return NULL;
6464
return dax_get_by_host(bdev->bd_disk->disk_name);
6565
}

drivers/md/md.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ static int rdevs_init_serial(struct mddev *mddev)
199199
static int rdev_need_serial(struct md_rdev *rdev)
200200
{
201201
return (rdev && rdev->mddev->bitmap_info.max_write_behind > 0 &&
202-
rdev->bdev->bd_queue->nr_hw_queues != 1 &&
202+
rdev->bdev->bd_disk->queue->nr_hw_queues != 1 &&
203203
test_bit(WriteMostly, &rdev->flags));
204204
}
205205

drivers/nvme/target/core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,7 @@ static int nvmet_p2pmem_ns_enable(struct nvmet_ns *ns)
467467
return -EINVAL;
468468
}
469469

470-
if (!blk_queue_pci_p2pdma(ns->bdev->bd_queue)) {
470+
if (!blk_queue_pci_p2pdma(ns->bdev->bd_disk->queue)) {
471471
pr_err("peer-to-peer DMA is not supported by the driver of %s\n",
472472
ns->device_path);
473473
return -EINVAL;

fs/block_dev.c

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -693,12 +693,12 @@ int bdev_read_page(struct block_device *bdev, sector_t sector,
693693
if (!ops->rw_page || bdev_get_integrity(bdev))
694694
return result;
695695

696-
result = blk_queue_enter(bdev->bd_queue, 0);
696+
result = blk_queue_enter(bdev->bd_disk->queue, 0);
697697
if (result)
698698
return result;
699699
result = ops->rw_page(bdev, sector + get_start_sect(bdev), page,
700700
REQ_OP_READ);
701-
blk_queue_exit(bdev->bd_queue);
701+
blk_queue_exit(bdev->bd_disk->queue);
702702
return result;
703703
}
704704

@@ -729,7 +729,7 @@ int bdev_write_page(struct block_device *bdev, sector_t sector,
729729

730730
if (!ops->rw_page || bdev_get_integrity(bdev))
731731
return -EOPNOTSUPP;
732-
result = blk_queue_enter(bdev->bd_queue, 0);
732+
result = blk_queue_enter(bdev->bd_disk->queue, 0);
733733
if (result)
734734
return result;
735735

@@ -742,7 +742,7 @@ int bdev_write_page(struct block_device *bdev, sector_t sector,
742742
clean_page_buffers(page);
743743
unlock_page(page);
744744
}
745-
blk_queue_exit(bdev->bd_queue);
745+
blk_queue_exit(bdev->bd_disk->queue);
746746
return result;
747747
}
748748

@@ -1568,7 +1568,6 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, int for_part)
15681568
if (!bdev->bd_openers) {
15691569
first_open = true;
15701570
bdev->bd_disk = disk;
1571-
bdev->bd_queue = disk->queue;
15721571
bdev->bd_contains = bdev;
15731572
bdev->bd_partno = partno;
15741573

@@ -1589,7 +1588,6 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, int for_part)
15891588
disk_put_part(bdev->bd_part);
15901589
bdev->bd_part = NULL;
15911590
bdev->bd_disk = NULL;
1592-
bdev->bd_queue = NULL;
15931591
mutex_unlock(&bdev->bd_mutex);
15941592
disk_unblock_events(disk);
15951593
put_disk_and_module(disk);
@@ -1666,7 +1664,6 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, int for_part)
16661664
disk_put_part(bdev->bd_part);
16671665
bdev->bd_disk = NULL;
16681666
bdev->bd_part = NULL;
1669-
bdev->bd_queue = NULL;
16701667
if (bdev != bdev->bd_contains)
16711668
__blkdev_put(bdev->bd_contains, mode, 1);
16721669
bdev->bd_contains = NULL;

fs/direct-io.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1387,8 +1387,8 @@ ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
13871387
* Attempt to prefetch the pieces we likely need later.
13881388
*/
13891389
prefetch(&bdev->bd_disk->part_tbl);
1390-
prefetch(bdev->bd_queue);
1391-
prefetch((char *)bdev->bd_queue + SMP_CACHE_BYTES);
1390+
prefetch(bdev->bd_disk->queue);
1391+
prefetch((char *)bdev->bd_disk->queue + SMP_CACHE_BYTES);
13921392

13931393
return do_blockdev_direct_IO(iocb, inode, bdev, iter, get_block,
13941394
end_io, submit_io, flags);

fs/xfs/xfs_pwork.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,5 +132,5 @@ xfs_pwork_guess_datadev_parallelism(
132132
* For now we'll go with the most conservative setting possible,
133133
* which is two threads for an SSD and 1 thread everywhere else.
134134
*/
135-
return blk_queue_nonrot(btp->bt_bdev->bd_queue) ? 2 : 1;
135+
return blk_queue_nonrot(btp->bt_bdev->bd_disk->queue) ? 2 : 1;
136136
}

include/linux/blk_types.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ struct block_device {
3939
unsigned bd_part_count;
4040
int bd_invalidated;
4141
struct gendisk * bd_disk;
42-
struct request_queue * bd_queue;
4342
struct backing_dev_info *bd_bdi;
4443
struct list_head bd_list;
4544
/*

mm/swapfile.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2929,7 +2929,7 @@ static int claim_swapfile(struct swap_info_struct *p, struct inode *inode)
29292929
* write only restriction. Hence zoned block devices are not
29302930
* suitable for swapping. Disallow them here.
29312931
*/
2932-
if (blk_queue_is_zoned(p->bdev->bd_queue))
2932+
if (blk_queue_is_zoned(p->bdev->bd_disk->queue))
29332933
return -EINVAL;
29342934
p->flags |= SWP_BLKDEV;
29352935
} else if (S_ISREG(inode->i_mode)) {

0 commit comments

Comments
 (0)