Skip to content

Commit e6a38c5

Browse files
mkalderondledford
authored andcommitted
RDMA/qedr: Add support for registering an iWARP device
There are slight differences between iWARP and RoCE in the ibdev registration. This patch handles the changes. Signed-off-by: Michal Kalderon <[email protected]> Signed-off-by: Ram Amrani <[email protected]> Signed-off-by: Ariel Elior <[email protected]> Signed-off-by: Doug Ledford <[email protected]>
1 parent 99d195c commit e6a38c5

File tree

4 files changed

+97
-26
lines changed

4 files changed

+97
-26
lines changed

drivers/infiniband/hw/qedr/main.c

Lines changed: 78 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@
3333
#include <rdma/ib_verbs.h>
3434
#include <rdma/ib_addr.h>
3535
#include <rdma/ib_user_verbs.h>
36+
#include <rdma/iw_cm.h>
37+
#include <rdma/ib_mad.h>
3638
#include <linux/netdevice.h>
3739
#include <linux/iommu.h>
3840
#include <linux/pci.h>
@@ -94,8 +96,75 @@ static struct net_device *qedr_get_netdev(struct ib_device *dev, u8 port_num)
9496
return qdev->ndev;
9597
}
9698

99+
int qedr_roce_port_immutable(struct ib_device *ibdev, u8 port_num,
100+
struct ib_port_immutable *immutable)
101+
{
102+
struct ib_port_attr attr;
103+
int err;
104+
105+
err = qedr_query_port(ibdev, port_num, &attr);
106+
if (err)
107+
return err;
108+
109+
immutable->pkey_tbl_len = attr.pkey_tbl_len;
110+
immutable->gid_tbl_len = attr.gid_tbl_len;
111+
immutable->core_cap_flags = RDMA_CORE_PORT_IBA_ROCE |
112+
RDMA_CORE_PORT_IBA_ROCE_UDP_ENCAP;
113+
immutable->max_mad_size = IB_MGMT_MAD_SIZE;
114+
115+
return 0;
116+
}
117+
118+
int qedr_iw_port_immutable(struct ib_device *ibdev, u8 port_num,
119+
struct ib_port_immutable *immutable)
120+
{
121+
struct ib_port_attr attr;
122+
int err;
123+
124+
err = qedr_query_port(ibdev, port_num, &attr);
125+
if (err)
126+
return err;
127+
128+
immutable->pkey_tbl_len = 1;
129+
immutable->gid_tbl_len = 1;
130+
immutable->core_cap_flags = RDMA_CORE_PORT_IWARP;
131+
immutable->max_mad_size = 0;
132+
133+
return 0;
134+
}
135+
136+
int qedr_iw_register_device(struct qedr_dev *dev)
137+
{
138+
dev->ibdev.node_type = RDMA_NODE_RNIC;
139+
dev->ibdev.query_gid = qedr_iw_query_gid;
140+
141+
dev->ibdev.get_port_immutable = qedr_iw_port_immutable;
142+
143+
dev->ibdev.iwcm = kzalloc(sizeof(*dev->ibdev.iwcm), GFP_KERNEL);
144+
if (!dev->ibdev.iwcm)
145+
return -ENOMEM;
146+
147+
memcpy(dev->ibdev.iwcm->ifname,
148+
dev->ndev->name, sizeof(dev->ibdev.iwcm->ifname));
149+
150+
return 0;
151+
}
152+
153+
void qedr_roce_register_device(struct qedr_dev *dev)
154+
{
155+
dev->ibdev.node_type = RDMA_NODE_IB_CA;
156+
dev->ibdev.query_gid = qedr_query_gid;
157+
158+
dev->ibdev.add_gid = qedr_add_gid;
159+
dev->ibdev.del_gid = qedr_del_gid;
160+
161+
dev->ibdev.get_port_immutable = qedr_roce_port_immutable;
162+
}
163+
97164
static int qedr_register_device(struct qedr_dev *dev)
98165
{
166+
int rc;
167+
99168
strlcpy(dev->ibdev.name, "qedr%d", IB_DEVICE_NAME_MAX);
100169

101170
dev->ibdev.node_guid = dev->attr.node_guid;
@@ -123,18 +192,21 @@ static int qedr_register_device(struct qedr_dev *dev)
123192
QEDR_UVERBS(POST_SEND) |
124193
QEDR_UVERBS(POST_RECV);
125194

195+
if (IS_IWARP(dev)) {
196+
rc = qedr_iw_register_device(dev);
197+
if (rc)
198+
return rc;
199+
} else {
200+
qedr_roce_register_device(dev);
201+
}
202+
126203
dev->ibdev.phys_port_cnt = 1;
127204
dev->ibdev.num_comp_vectors = dev->num_cnq;
128-
dev->ibdev.node_type = RDMA_NODE_IB_CA;
129205

130206
dev->ibdev.query_device = qedr_query_device;
131207
dev->ibdev.query_port = qedr_query_port;
132208
dev->ibdev.modify_port = qedr_modify_port;
133209

134-
dev->ibdev.query_gid = qedr_query_gid;
135-
dev->ibdev.add_gid = qedr_add_gid;
136-
dev->ibdev.del_gid = qedr_del_gid;
137-
138210
dev->ibdev.alloc_ucontext = qedr_alloc_ucontext;
139211
dev->ibdev.dealloc_ucontext = qedr_dealloc_ucontext;
140212
dev->ibdev.mmap = qedr_mmap;
@@ -168,7 +240,7 @@ static int qedr_register_device(struct qedr_dev *dev)
168240
dev->ibdev.post_recv = qedr_post_recv;
169241

170242
dev->ibdev.process_mad = qedr_process_mad;
171-
dev->ibdev.get_port_immutable = qedr_port_immutable;
243+
172244
dev->ibdev.get_netdev = qedr_get_netdev;
173245

174246
dev->ibdev.dev.parent = &dev->pdev->dev;

drivers/infiniband/hw/qedr/qedr.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@
4444
#define QEDR_MODULE_VERSION "8.10.10.0"
4545
#define QEDR_NODE_DESC "QLogic 579xx RoCE HCA"
4646
#define DP_NAME(dev) ((dev)->ibdev.name)
47+
#define IS_IWARP(_dev) ((_dev)->rdma_type == QED_RDMA_TYPE_IWARP)
48+
#define IS_ROCE(_dev) ((_dev)->rdma_type == QED_RDMA_TYPE_ROCE)
4749

4850
#define DP_DEBUG(dev, module, fmt, ...) \
4951
pr_debug("(%s) " module ": " fmt, \
@@ -161,6 +163,7 @@ struct qedr_dev {
161163
struct qedr_cq *gsi_sqcq;
162164
struct qedr_cq *gsi_rqcq;
163165
struct qedr_qp *gsi_qp;
166+
enum qed_rdma_type rdma_type;
164167

165168
unsigned long enet_state;
166169
};

drivers/infiniband/hw/qedr/verbs.c

Lines changed: 14 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,20 @@ int qedr_query_pkey(struct ib_device *ibdev, u8 port, u16 index, u16 *pkey)
7070
return 0;
7171
}
7272

73+
int qedr_iw_query_gid(struct ib_device *ibdev, u8 port,
74+
int index, union ib_gid *sgid)
75+
{
76+
struct qedr_dev *dev = get_qedr_dev(ibdev);
77+
78+
memset(sgid->raw, 0, sizeof(sgid->raw));
79+
ether_addr_copy(sgid->raw, dev->ndev->dev_addr);
80+
81+
DP_DEBUG(dev, QEDR_MSG_INIT, "QUERY sgid[%d]=%llx:%llx\n", index,
82+
sgid->global.interface_id, sgid->global.subnet_prefix);
83+
84+
return 0;
85+
}
86+
7387
int qedr_query_gid(struct ib_device *ibdev, u8 port, int index,
7488
union ib_gid *sgid)
7589
{
@@ -3600,23 +3614,3 @@ int qedr_process_mad(struct ib_device *ibdev, int process_mad_flags,
36003614
mad_hdr->method, mad_hdr->mgmt_class, mad_hdr->status);
36013615
return IB_MAD_RESULT_SUCCESS;
36023616
}
3603-
3604-
int qedr_port_immutable(struct ib_device *ibdev, u8 port_num,
3605-
struct ib_port_immutable *immutable)
3606-
{
3607-
struct ib_port_attr attr;
3608-
int err;
3609-
3610-
immutable->core_cap_flags = RDMA_CORE_PORT_IBA_ROCE |
3611-
RDMA_CORE_PORT_IBA_ROCE_UDP_ENCAP;
3612-
3613-
err = ib_query_port(ibdev, port_num, &attr);
3614-
if (err)
3615-
return err;
3616-
3617-
immutable->pkey_tbl_len = attr.pkey_tbl_len;
3618-
immutable->gid_tbl_len = attr.gid_tbl_len;
3619-
immutable->max_mad_size = IB_MGMT_MAD_SIZE;
3620-
3621-
return 0;
3622-
}

drivers/infiniband/hw/qedr/verbs.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ int qedr_modify_port(struct ib_device *, u8 port, int mask,
3939
struct ib_port_modify *props);
4040

4141
int qedr_query_gid(struct ib_device *, u8 port, int index, union ib_gid *gid);
42+
int qedr_iw_query_gid(struct ib_device *ibdev, u8 port,
43+
int index, union ib_gid *gid);
4244

4345
int qedr_query_pkey(struct ib_device *, u8 port, u16 index, u16 *pkey);
4446

0 commit comments

Comments
 (0)