Skip to content

Commit e6ba820

Browse files
jwrdegoedeholtmann
authored andcommitted
Bluetooth: hci_bcm: Remove irq-active-low DMI quirk for the Thinkpad 8
Interrupts specified through an "Interrupt" ACPI resource (versus through a "GpioInt" resource) are now always assumed to be active low. When this change was originally made the Thinkpad 8 quirk was kept around because it was uncertain if the Thinkpad 8 uses an "Interrupt" or a "GpioInt" resource. Bug https://bugzilla.kernel.org/show_bug.cgi?id=196701 has a DSDT for the Thinkpad 8 attached and it uses an "Interrupt" resource, so the quirk is not necessary and the quirk, as well as the irq-active-low quirk handling code can be removed. Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Marcel Holtmann <[email protected]>
1 parent 2b05393 commit e6ba820

File tree

1 file changed

+0
-20
lines changed

1 file changed

+0
-20
lines changed

drivers/bluetooth/hci_bcm.c

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -809,18 +809,6 @@ static const struct dmi_system_id bcm_broken_irq_dmi_table[] = {
809809
};
810810

811811
#ifdef CONFIG_ACPI
812-
/* IRQ polarity of some chipsets are not defined correctly in ACPI table. */
813-
static const struct dmi_system_id bcm_active_low_irq_dmi_table[] = {
814-
{ /* Handle ThinkPad 8 tablets with BCM2E55 chipset ACPI ID */
815-
.ident = "Lenovo ThinkPad 8",
816-
.matches = {
817-
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
818-
DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "ThinkPad 8"),
819-
},
820-
},
821-
{ }
822-
};
823-
824812
static int bcm_resource(struct acpi_resource *ares, void *data)
825813
{
826814
struct bcm_device *dev = data;
@@ -967,7 +955,6 @@ static int bcm_get_resources(struct bcm_device *dev)
967955
static int bcm_acpi_probe(struct bcm_device *dev)
968956
{
969957
LIST_HEAD(resources);
970-
const struct dmi_system_id *dmi_id;
971958
const struct acpi_gpio_mapping *gpio_mapping = acpi_bcm_int_last_gpios;
972959
struct resource_entry *entry;
973960
int ret;
@@ -1014,13 +1001,6 @@ static int bcm_acpi_probe(struct bcm_device *dev)
10141001
dev->irq_active_low = irq_polarity;
10151002
dev_warn(dev->dev, "Overwriting IRQ polarity to active %s by module-param\n",
10161003
dev->irq_active_low ? "low" : "high");
1017-
} else {
1018-
dmi_id = dmi_first_match(bcm_active_low_irq_dmi_table);
1019-
if (dmi_id) {
1020-
dev_warn(dev->dev, "%s: Overwriting IRQ polarity to active low",
1021-
dmi_id->ident);
1022-
dev->irq_active_low = true;
1023-
}
10241004
}
10251005

10261006
return 0;

0 commit comments

Comments
 (0)