Skip to content

Commit e73bdd2

Browse files
committed
drm/i915: Disentangle i915_drv.h includes
Separate out the layers of includes (linux, drm, intel, i915) so that it is a little easier to order our definitions between our multiple reentrant headers. A couple of headers needed fixes to make them more standalone (forgotten includes, forward declarations etc). Signed-off-by: Chris Wilson <[email protected]> Reviewed-by: Joonas Lahtinen <[email protected]> Link: http://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 0a793ad commit e73bdd2

File tree

3 files changed

+21
-12
lines changed

3 files changed

+21
-12
lines changed

drivers/gpu/drm/i915/i915_drv.h

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -33,27 +33,32 @@
3333
#include <uapi/drm/i915_drm.h>
3434
#include <uapi/drm/drm_fourcc.h>
3535

36-
#include <drm/drmP.h>
37-
#include "i915_params.h"
38-
#include "i915_reg.h"
39-
#include "intel_bios.h"
40-
#include "intel_ringbuffer.h"
41-
#include "intel_lrc.h"
42-
#include "i915_gem_gtt.h"
43-
#include "i915_gem_render_state.h"
4436
#include <linux/io-mapping.h>
4537
#include <linux/i2c.h>
4638
#include <linux/i2c-algo-bit.h>
47-
#include <drm/intel-gtt.h>
48-
#include <drm/drm_legacy.h> /* for struct drm_dma_handle */
49-
#include <drm/drm_gem.h>
5039
#include <linux/backlight.h>
5140
#include <linux/hashtable.h>
5241
#include <linux/intel-iommu.h>
5342
#include <linux/kref.h>
5443
#include <linux/pm_qos.h>
55-
#include "intel_guc.h"
44+
#include <linux/shmem_fs.h>
45+
46+
#include <drm/drmP.h>
47+
#include <drm/intel-gtt.h>
48+
#include <drm/drm_legacy.h> /* for struct drm_dma_handle */
49+
#include <drm/drm_gem.h>
50+
51+
#include "i915_params.h"
52+
#include "i915_reg.h"
53+
54+
#include "intel_bios.h"
5655
#include "intel_dpll_mgr.h"
56+
#include "intel_guc.h"
57+
#include "intel_lrc.h"
58+
#include "intel_ringbuffer.h"
59+
60+
#include "i915_gem_gtt.h"
61+
#include "i915_gem_render_state.h"
5762

5863
/* General customization:
5964
*/

drivers/gpu/drm/i915/intel_guc.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@
2727
#include "intel_guc_fwif.h"
2828
#include "i915_guc_reg.h"
2929

30+
struct drm_i915_gem_request;
31+
3032
struct i915_guc_client {
3133
struct drm_i915_gem_object *client_obj;
3234
struct intel_context *owner;

drivers/gpu/drm/i915/intel_lrc.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424
#ifndef _INTEL_LRC_H_
2525
#define _INTEL_LRC_H_
2626

27+
#include "intel_ringbuffer.h"
28+
2729
#define GEN8_LR_CONTEXT_ALIGN 4096
2830

2931
/* Execlists regs */

0 commit comments

Comments
 (0)