Skip to content

Commit e749d32

Browse files
Wei Yongjuncminyard
authored andcommitted
ipmi/powernv: Fix error return code in ipmi_powernv_probe()
Fix to return a negative error code from the request_irq() error handling case instead of 0, as done elsewhere in this function. Fixes: dce143c ("ipmi/powernv: Convert to irq event interface") Signed-off-by: Wei Yongjun <[email protected]> Reviewed-by: Alexey Kardashevskiy <[email protected]> Signed-off-by: Corey Minyard <[email protected]>
1 parent 5516e21 commit e749d32

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/char/ipmi/ipmi_powernv.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -250,8 +250,9 @@ static int ipmi_powernv_probe(struct platform_device *pdev)
250250
ipmi->irq = opal_event_request(prop);
251251
}
252252

253-
if (request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
254-
"opal-ipmi", ipmi)) {
253+
rc = request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
254+
"opal-ipmi", ipmi);
255+
if (rc) {
255256
dev_warn(dev, "Unable to request irq\n");
256257
goto err_dispose;
257258
}

0 commit comments

Comments
 (0)