Skip to content

Commit e79e0e1

Browse files
AstralBobAndreas Gruenbacher
authored andcommitted
gfs2: Don't reject a supposedly full bitmap if we have blocks reserved
Before this patch, you could get into situations like this: 1. Process 1 searches for X free blocks, finds them, makes a reservation 2. Process 2 searches for free blocks in the same rgrp, but now the bitmap is full because process 1's reservation is skipped over. So it marks the bitmap as GBF_FULL. 3. Process 1 tries to allocate blocks from its own reservation, but since the GBF_FULL bit is set, it skips over the rgrp and searches elsewhere, thus not using its own reservation. This patch adds an additional check to allow processes to use their own reservations. Signed-off-by: Bob Peterson <[email protected]> Signed-off-by: Andreas Gruenbacher <[email protected]>
1 parent b7eba89 commit e79e0e1

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

fs/gfs2/rgrp.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1687,7 +1687,8 @@ static int gfs2_rbm_find(struct gfs2_rbm *rbm, u8 state, u32 *minext,
16871687

16881688
while(1) {
16891689
bi = rbm_bi(rbm);
1690-
if (test_bit(GBF_FULL, &bi->bi_flags) &&
1690+
if ((ip == NULL || !gfs2_rs_active(&ip->i_res)) &&
1691+
test_bit(GBF_FULL, &bi->bi_flags) &&
16911692
(state == GFS2_BLKST_FREE))
16921693
goto next_bitmap;
16931694

0 commit comments

Comments
 (0)