Skip to content

Commit e7f8df0

Browse files
Jiri Pirkokuba-moo
authored andcommitted
dpll: move xa_erase() call in to match dpll_pin_alloc() error path order
This is cosmetics. Move the call of xa_erase() in dpll_pin_put() so the order of cleanup calls matches the error path of dpll_pin_alloc(). Signed-off-by: Jiri Pirko <[email protected]> Reviewed-by: Vadim Fedorenko <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 5264ab6 commit e7f8df0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/dpll/dpll_core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -560,9 +560,9 @@ void dpll_pin_put(struct dpll_pin *pin)
560560
{
561561
mutex_lock(&dpll_lock);
562562
if (refcount_dec_and_test(&pin->refcount)) {
563+
xa_erase(&dpll_pin_xa, pin->id);
563564
xa_destroy(&pin->dpll_refs);
564565
xa_destroy(&pin->parent_refs);
565-
xa_erase(&dpll_pin_xa, pin->id);
566566
dpll_pin_prop_free(&pin->prop);
567567
kfree(pin);
568568
}

0 commit comments

Comments
 (0)