Skip to content

Commit e8504ee

Browse files
vsyrjaladanvet
authored andcommitted
drm/i915: Write the SDVO reg twice on IBX
On IBX the SDVO/HDMI register write may be masked when enabling the port, so it may need to written twice. The HDMI code does this, but the SDVO code does not. Add the workaround to the SDVO code as well. Signed-off-by: Ville Syrjälä <[email protected]> Reviewed-by: Jesse Barnes <[email protected]> Signed-off-by: Daniel Vetter <[email protected]>
1 parent e3ef447 commit e8504ee

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

drivers/gpu/drm/i915/intel_sdvo.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,14 @@ static void intel_sdvo_write_sdvox(struct intel_sdvo *intel_sdvo, u32 val)
243243
if (intel_sdvo->sdvo_reg == PCH_SDVOB) {
244244
I915_WRITE(intel_sdvo->sdvo_reg, val);
245245
POSTING_READ(intel_sdvo->sdvo_reg);
246+
/*
247+
* HW workaround, need to write this twice for issue
248+
* that may result in first write getting masked.
249+
*/
250+
if (HAS_PCH_IBX(dev)) {
251+
I915_WRITE(intel_sdvo->sdvo_reg, val);
252+
POSTING_READ(intel_sdvo->sdvo_reg);
253+
}
246254
return;
247255
}
248256

0 commit comments

Comments
 (0)