Skip to content

Commit e87be9b

Browse files
Wolfram Sangstorulf
authored andcommitted
mmc: tmio: remove broken and noisy debug macro
Some change for v4.14 broke the debug output for TMIO. But since it was not helpful to me and too noisy for my taste anyhow, let's just remove it instead of fixing it. We'll find something better if we'd need it... Signed-off-by: Wolfram Sang <[email protected]> Signed-off-by: Ulf Hansson <[email protected]>
1 parent 2bd6bf0 commit e87be9b

File tree

1 file changed

+0
-47
lines changed

1 file changed

+0
-47
lines changed

drivers/mmc/host/tmio_mmc_core.c

Lines changed: 0 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -129,50 +129,6 @@ static int tmio_mmc_next_sg(struct tmio_mmc_host *host)
129129

130130
#define CMDREQ_TIMEOUT 5000
131131

132-
#ifdef CONFIG_MMC_DEBUG
133-
134-
#define STATUS_TO_TEXT(a, status, i) \
135-
do { \
136-
if ((status) & TMIO_STAT_##a) { \
137-
if ((i)++) \
138-
printk(KERN_DEBUG " | "); \
139-
printk(KERN_DEBUG #a); \
140-
} \
141-
} while (0)
142-
143-
static void pr_debug_status(u32 status)
144-
{
145-
int i = 0;
146-
147-
pr_debug("status: %08x = ", status);
148-
STATUS_TO_TEXT(CARD_REMOVE, status, i);
149-
STATUS_TO_TEXT(CARD_INSERT, status, i);
150-
STATUS_TO_TEXT(SIGSTATE, status, i);
151-
STATUS_TO_TEXT(WRPROTECT, status, i);
152-
STATUS_TO_TEXT(CARD_REMOVE_A, status, i);
153-
STATUS_TO_TEXT(CARD_INSERT_A, status, i);
154-
STATUS_TO_TEXT(SIGSTATE_A, status, i);
155-
STATUS_TO_TEXT(CMD_IDX_ERR, status, i);
156-
STATUS_TO_TEXT(STOPBIT_ERR, status, i);
157-
STATUS_TO_TEXT(ILL_FUNC, status, i);
158-
STATUS_TO_TEXT(CMD_BUSY, status, i);
159-
STATUS_TO_TEXT(CMDRESPEND, status, i);
160-
STATUS_TO_TEXT(DATAEND, status, i);
161-
STATUS_TO_TEXT(CRCFAIL, status, i);
162-
STATUS_TO_TEXT(DATATIMEOUT, status, i);
163-
STATUS_TO_TEXT(CMDTIMEOUT, status, i);
164-
STATUS_TO_TEXT(RXOVERFLOW, status, i);
165-
STATUS_TO_TEXT(TXUNDERRUN, status, i);
166-
STATUS_TO_TEXT(RXRDY, status, i);
167-
STATUS_TO_TEXT(TXRQ, status, i);
168-
STATUS_TO_TEXT(ILL_ACCESS, status, i);
169-
printk("\n");
170-
}
171-
172-
#else
173-
#define pr_debug_status(s) do { } while (0)
174-
#endif
175-
176132
static void tmio_mmc_enable_sdio_irq(struct mmc_host *mmc, int enable)
177133
{
178134
struct tmio_mmc_host *host = mmc_priv(mmc);
@@ -762,9 +718,6 @@ irqreturn_t tmio_mmc_irq(int irq, void *devid)
762718
status = sd_ctrl_read16_and_16_as_32(host, CTL_STATUS);
763719
ireg = status & TMIO_MASK_IRQ & ~host->sdcard_irq_mask;
764720

765-
pr_debug_status(status);
766-
pr_debug_status(ireg);
767-
768721
/* Clear the status except the interrupt status */
769722
sd_ctrl_write32_as_16_and_16(host, CTL_STATUS, TMIO_MASK_IRQ);
770723

0 commit comments

Comments
 (0)