Skip to content

Commit e8848da

Browse files
gerd-rauschBrian Maly
authored andcommitted
Revert "net/rds: Allocate rds_ib_{incoming,frag}_slab on HCA NUMA nodeid"
This reverts commit 53c36cbf2612d2d8a3c4a1432585671ef952e3f8. Orabug: 33590962 Signed-off-by: Gerd Rausch <[email protected]> Reviewed-by: John Donnelly <[email protected]> Signed-off-by: Brian Maly <[email protected]>
1 parent 845a418 commit e8848da

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

net/rds/ib_recv.c

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,9 @@ struct kmem_cache *rds_ib_incoming_slab;
6363
struct kmem_cache *rds_ib_frag_slab;
6464
atomic_t rds_ib_allocation = ATOMIC_INIT(0);
6565

66-
static inline void *rds_ib_kmem_cache_alloc(struct kmem_cache *cachep, gfp_t flags,
67-
struct rds_ib_device *rds_ibdev)
66+
static inline void *rds_ib_kmem_cache_alloc(struct kmem_cache *cachep, gfp_t flags)
6867
{
69-
void *ent = kmem_cache_alloc_node(cachep, flags, rdsibdev_to_node(rds_ibdev));
68+
void *ent = kmem_cache_alloc(cachep, flags);
7069

7170
if (ent)
7271
rds_ib_stats_inc(s_ib_rx_cache_alloc);
@@ -245,7 +244,7 @@ static struct rds_ib_incoming *rds_ib_refill_one_inc(struct rds_ib_connection *i
245244
if (cache_item) {
246245
ibinc = container_of(cache_item, struct rds_ib_incoming, ii_cache_entry);
247246
} else {
248-
ibinc = rds_ib_kmem_cache_alloc(rds_ib_incoming_slab, slab_mask, ic->rds_ibdev);
247+
ibinc = rds_ib_kmem_cache_alloc(rds_ib_incoming_slab, slab_mask);
249248
if (!ibinc)
250249
return NULL;
251250
rds_ib_stats_inc(s_ib_rx_total_incs);
@@ -287,7 +286,7 @@ static struct rds_page_frag *rds_ib_refill_one_frag(struct rds_ib_connection *ic
287286
return NULL;
288287
}
289288

290-
frag = rds_ib_kmem_cache_alloc(rds_ib_frag_slab, slab_mask, ic->rds_ibdev);
289+
frag = rds_ib_kmem_cache_alloc(rds_ib_frag_slab, slab_mask);
291290
if (!frag) {
292291
atomic_sub(ic->i_frag_pages, &rds_ib_allocation);
293292
rds_ib_stats_inc(s_ib_rx_cache_put_alloc);
@@ -459,15 +458,15 @@ static int rds_ib_srq_prefill_one(struct rds_ib_device *rds_ibdev,
459458
}
460459

461460
if (!recv->r_ibinc) {
462-
recv->r_ibinc = rds_ib_kmem_cache_alloc(rds_ib_incoming_slab, slab_mask, rds_ibdev);
461+
recv->r_ibinc = rds_ib_kmem_cache_alloc(rds_ib_incoming_slab, slab_mask);
463462
if (!recv->r_ibinc)
464463
goto out;
465464
rds_ib_stats_inc(s_ib_rx_total_incs);
466465
INIT_LIST_HEAD(&recv->r_ibinc->ii_frags);
467466
}
468467

469468
WARN_ON_ONCE(recv->r_frag); /* leak! */
470-
recv->r_frag = rds_ib_kmem_cache_alloc(rds_ib_frag_slab, slab_mask, rds_ibdev);
469+
recv->r_frag = rds_ib_kmem_cache_alloc(rds_ib_frag_slab, slab_mask);
471470
if (!recv->r_frag)
472471
goto out;
473472
sg_init_table(recv->r_frag->f_sg, num_sge);

0 commit comments

Comments
 (0)