Skip to content

Commit e8f6b49

Browse files
committed
drm/i915/execlists: Flush the post-sync breadcrumb write harder
Quite rarely we see that the CS completion event fires before the breadcrumb is coherent, which presumably is a result of the CS_STALL not waiting for the post-sync operation. Try throwing in a DC_FLUSH into the following pipecontrol to see if that makes any difference. Signed-off-by: Chris Wilson <[email protected]> Cc: Mika Kuoppala <[email protected]> Acked-by: Mika Kuoppala <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent c4e6488 commit e8f6b49

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/gpu/drm/i915/gt/intel_lrc.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2923,8 +2923,10 @@ static u32 *gen8_emit_fini_breadcrumb_rcs(struct i915_request *request, u32 *cs)
29232923
PIPE_CONTROL_DC_FLUSH_ENABLE);
29242924

29252925
/* XXX flush+write+CS_STALL all in one upsets gem_concurrent_blt:kbl */
2926+
/* XXX DC_FLUSH for post-sync write? (cf early context-switch bug) */
29262927
cs = gen8_emit_pipe_control(cs,
29272928
PIPE_CONTROL_FLUSH_ENABLE |
2929+
PIPE_CONTROL_DC_FLUSH_ENABLE |
29282930
PIPE_CONTROL_CS_STALL,
29292931
0);
29302932

0 commit comments

Comments
 (0)