rds: Rename rds_send_ping to rds_send_hs_ping

Commit 041dc3e ("Backport multipath RDS from upstream to UEK4")
introduced a function called rds_send_ping().

However, this function does not send a _ping_ per se, but a special
RDS MultiPath handshake probe.

Renamed to avoid confusion.

Orabug: 30418039

Fixes: 041dc3e ("Backport multipath RDS from upstream to UEK4")
Signed-off-by: Håkon Bugge <[email protected]>
Reviewed-by: Ka-Cheong Poon <[email protected]>
Tested-by: Michael Nowak <[email protected]>

---

v1->v2:
	* Added Ka-Cheong's r-b
	* Added Mike's t-b

Signed-off-by: Somasundaram Krishnasamy <[email protected]>

Author: Hakon-Bugge

net/rds/rds.h

@@ -1244,7 +1244,7 @@ void rds_send_drop_acked(struct rds_connection *conn, u64 ack,
 void rds_send_path_drop_acked(struct rds_conn_path *cp, u64 ack,
 			      is_acked_func is_acked);
 void rds_send_remove_from_sock(struct list_head *messages, int status);
-void rds_send_ping(struct rds_connection *conn, int cp_index);
+void rds_send_hs_ping(struct rds_connection *conn, int cp_index);
 int rds_send_pong(struct rds_conn_path *cp, __be16 dport);
 int rds_send_hb(struct rds_connection *conn, int response);
 struct rds_message *rds_send_get_message(struct rds_connection *,

net/rds/send.c

@@ -1523,12 +1523,12 @@ int rds_sendmsg(struct socket *sock, struct msghdr *msg, size_t payload_len)
 			    rds_conn_path_down(&conn->c_path[0])) {
 				/* rds_connd_queue_reconnect_work() ensures
 				 * that only one request is queued.  And
-				 * rds_send_ping() ensures that only one ping
+				 * rds_send_hs_ping() ensures that only one ping
 				 * is outstanding.
 				 */
 				rds_cond_queue_reconnect_work(&conn->c_path[0],
 							      0);
-				rds_send_ping(conn, 0);
+				rds_send_hs_ping(conn, 0);
 			}
 			cpath = &conn->c_path[rds_send_mprds_hash(rs, conn)];
 		} else {
@@ -1799,7 +1799,7 @@ int rds_send_internal(struct rds_connection *conn, struct rds_sock *rs,
 }
 
 /*
- * send out a probe. Can be shared by rds_send_ping,
+ * send out a probe. Can be shared by rds_send_hs_ping,
  * rds_send_pong, rds_send_hb.
  */
 static int rds_send_probe(struct rds_conn_path *cp, __be16 sport,
@@ -1899,8 +1899,9 @@ rds_send_pong(struct rds_conn_path *cp, __be16 dport)
 	return rds_send_probe(cp, 0, dport, 0);
 }
 
+/* Send a hand-shake ping */
 void
-rds_send_ping(struct rds_connection *conn, int cp_index)
+rds_send_hs_ping(struct rds_connection *conn, int cp_index)
 {
 	unsigned long flags;
 	struct rds_conn_path *cp = &conn->c_path[cp_index];
@@ -1916,4 +1917,4 @@ rds_send_ping(struct rds_connection *conn, int cp_index)
 	rds_stats_inc(s_send_mprds_ping);
 	rds_send_probe(cp, cpu_to_be16(RDS_FLAG_PROBE_PORT), 0, 0);
 }
-EXPORT_SYMBOL_GPL(rds_send_ping);
+EXPORT_SYMBOL_GPL(rds_send_hs_ping);

net/rds/tcp_listen.c

@@ -225,7 +225,7 @@ int rds_tcp_accept_one(struct socket *sock)
 	new_sock = NULL;
 	ret = 0;
 	if (conn->c_npaths == 0)
-		rds_send_ping(cp->cp_conn, cp->cp_index);
+		rds_send_hs_ping(cp->cp_conn, cp->cp_index);
 	goto out;
 rst_nsk:
 	/* reset the newly returned accept sock and bail.