Skip to content

Commit ea8564c

Browse files
lrq-maxdavem330
authored andcommitted
openvswitch: change type of UPCALL_PID attribute to NLA_UNSPEC
userspace openvswitch patch "(dpif-linux: Implement the API functions to allow multiple handler threads read upcall)" changes its type from U32 to UNSPEC, but leave the kernel unchanged and after kernel 6e237d0 "(netlink: Relax attr validation for fixed length types)", this bug is exposed by the below warning [ 57.215841] netlink: 'ovs-vswitchd': attribute type 5 has an invalid length. Fixes: 5cd667b ("openvswitch: Allow each vport to have an array of 'port_id's") Signed-off-by: Li RongQing <[email protected]> Acked-by: Pravin B Shelar <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent c1d419d commit ea8564c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/openvswitch/datapath.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2294,7 +2294,7 @@ static const struct nla_policy vport_policy[OVS_VPORT_ATTR_MAX + 1] = {
22942294
[OVS_VPORT_ATTR_STATS] = { .len = sizeof(struct ovs_vport_stats) },
22952295
[OVS_VPORT_ATTR_PORT_NO] = { .type = NLA_U32 },
22962296
[OVS_VPORT_ATTR_TYPE] = { .type = NLA_U32 },
2297-
[OVS_VPORT_ATTR_UPCALL_PID] = { .type = NLA_U32 },
2297+
[OVS_VPORT_ATTR_UPCALL_PID] = { .type = NLA_UNSPEC },
22982298
[OVS_VPORT_ATTR_OPTIONS] = { .type = NLA_NESTED },
22992299
[OVS_VPORT_ATTR_IFINDEX] = { .type = NLA_U32 },
23002300
[OVS_VPORT_ATTR_NETNSID] = { .type = NLA_S32 },

0 commit comments

Comments
 (0)