Skip to content

Commit eb99108

Browse files
jirislabyJiri Kosina
authored andcommitted
HID: fix lock imbalance in hiddev
Don't forget to unlock_kernel() in hiddev_ioctl_usage(). Added in 7961df1 (HID: Switch hiddev to unlocked_ioctl). Corresponing sparse warning: drivers/hid/usbhid/hiddev.c:515:10: warning: context imbalance in 'hiddev_ioctl_usage': wrong count at exit drivers/hid/usbhid/hiddev.c:515:10: context 'kernel_lock': wanted 0, got 1 Signed-off-by: Jiri Slaby <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent 0f2c594 commit eb99108

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/hid/usbhid/hiddev.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -436,8 +436,7 @@ static noinline int hiddev_ioctl_usage(struct hiddev *hiddev, unsigned int cmd,
436436
if (copy_to_user(user_arg, uref, sizeof(*uref)))
437437
goto fault;
438438

439-
kfree(uref_multi);
440-
return 0;
439+
goto goodreturn;
441440

442441
default:
443442
if (cmd != HIDIOCGUSAGE &&

0 commit comments

Comments
 (0)