Skip to content

Commit eb9913b

Browse files
ZhangShurongbroonie
authored andcommitted
spi: tegra: Fix missing IRQ check in tegra_slink_probe()
This func misses checking for platform_get_irq()'s call and may passes the negative error codes to request_irq(), which takes unsigned IRQ #, causing it to fail with -EINVAL, overriding an original error code. Fix this by stop calling request_irq() with invalid IRQ #s. Fixes: dc4dc36 ("spi: tegra: add spi driver for SLINK controller") Signed-off-by: Zhang Shurong <[email protected]> Reviewed-by: Helen Koike <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 2d98bda commit eb9913b

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/spi/spi-tegra20-slink.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1086,6 +1086,8 @@ static int tegra_slink_probe(struct platform_device *pdev)
10861086
reset_control_deassert(tspi->rst);
10871087

10881088
spi_irq = platform_get_irq(pdev, 0);
1089+
if (spi_irq < 0)
1090+
return spi_irq;
10891091
tspi->irq = spi_irq;
10901092
ret = request_threaded_irq(tspi->irq, tegra_slink_isr,
10911093
tegra_slink_isr_thread, IRQF_ONESHOT,

0 commit comments

Comments
 (0)