Skip to content

Commit ed2eebb

Browse files
llandwerlin-inteldanvet
authored andcommitted
drm/i915: add missing condition for committing planes on crtc
The i915 driver checks for color management properties changes as part of a plane update. Therefore a color management update must imply a plane update, otherwise we never update the transformation matrixes and degamma/gamma LUTs. v2: add comment about moving the commit of color management registers to an async worker v3: Commit color management register right after vblank v4: Move back color management commit condition together with planes commit v5: Trigger color management commit through the planes commit (Daniel) v6: Make plane change update more readable Fixes: 20a34e7 (drm/i915: Update color management during vblank evasion.) Cc: Maarten Lankhorst <[email protected]> Cc: Ville Syrjälä <[email protected]> Cc: Daniel Vetter <[email protected]> Cc: [email protected] Signed-off-by: Lionel Landwerlin <[email protected]> References: https://lkml.org/lkml/2016/7/14/614 Reviewed-and-tested-by: Mario Kleiner <[email protected]> Link: http://patchwork.freedesktop.org/patch/msgid/[email protected] (cherry picked from commit e7852a4) Signed-off-by: Daniel Vetter <[email protected]>
1 parent c71d4d5 commit ed2eebb

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

drivers/gpu/drm/i915/intel_display.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11997,6 +11997,12 @@ static int intel_crtc_atomic_check(struct drm_crtc *crtc,
1199711997
ret = intel_color_check(crtc, crtc_state);
1199811998
if (ret)
1199911999
return ret;
12000+
12001+
/*
12002+
* Changing color management on Intel hardware is
12003+
* handled as part of planes update.
12004+
*/
12005+
crtc_state->planes_changed = true;
1200012006
}
1200112007

1200212008
ret = 0;

0 commit comments

Comments
 (0)