Skip to content

Commit ed7a58c

Browse files
LorenzoBianconiAlexei Starovoitov
authored andcommitted
net: marvell: rely on xdp_update_skb_shared_info utility routine
Rely on xdp_update_skb_shared_info routine in order to avoid resetting frags array in skb_shared_info structure building the skb in mvneta_swbm_build_skb(). Frags array is expected to be initialized by the receiving driver building the xdp_buff and here we just need to update memory metadata. Acked-by: Toke Hoiland-Jorgensen <[email protected]> Acked-by: John Fastabend <[email protected]> Signed-off-by: Lorenzo Bianconi <[email protected]> Link: https://lore.kernel.org/r/e0dad97f5d02b13f189f99f1e5bc8e61bef73412.1642758637.git.lorenzo@kernel.org Signed-off-by: Alexei Starovoitov <[email protected]>
1 parent d65a190 commit ed7a58c

File tree

1 file changed

+10
-13
lines changed

1 file changed

+10
-13
lines changed

drivers/net/ethernet/marvell/mvneta.c

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2332,8 +2332,12 @@ mvneta_swbm_add_rx_fragment(struct mvneta_port *pp,
23322332
skb_frag_size_set(frag, data_len);
23332333
__skb_frag_set_page(frag, page);
23342334

2335-
if (!xdp_buff_has_frags(xdp))
2335+
if (!xdp_buff_has_frags(xdp)) {
2336+
sinfo->xdp_frags_size = *size;
23362337
xdp_buff_set_frags_flag(xdp);
2338+
}
2339+
if (page_is_pfmemalloc(page))
2340+
xdp_buff_set_frag_pfmemalloc(xdp);
23372341
} else {
23382342
page_pool_put_full_page(rxq->page_pool, page, true);
23392343
}
@@ -2347,7 +2351,6 @@ mvneta_swbm_build_skb(struct mvneta_port *pp, struct page_pool *pool,
23472351
struct skb_shared_info *sinfo = xdp_get_shared_info_from_buff(xdp);
23482352
struct sk_buff *skb;
23492353
u8 num_frags;
2350-
int i;
23512354

23522355
if (unlikely(xdp_buff_has_frags(xdp)))
23532356
num_frags = sinfo->nr_frags;
@@ -2362,18 +2365,12 @@ mvneta_swbm_build_skb(struct mvneta_port *pp, struct page_pool *pool,
23622365
skb_put(skb, xdp->data_end - xdp->data);
23632366
skb->ip_summed = mvneta_rx_csum(pp, desc_status);
23642367

2365-
if (likely(!xdp_buff_has_frags(xdp)))
2366-
goto out;
2367-
2368-
for (i = 0; i < num_frags; i++) {
2369-
skb_frag_t *frag = &sinfo->frags[i];
2370-
2371-
skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags,
2372-
skb_frag_page(frag), skb_frag_off(frag),
2373-
skb_frag_size(frag), PAGE_SIZE);
2374-
}
2368+
if (unlikely(xdp_buff_has_frags(xdp)))
2369+
xdp_update_skb_shared_info(skb, num_frags,
2370+
sinfo->xdp_frags_size,
2371+
num_frags * xdp->frame_sz,
2372+
xdp_buff_is_frag_pfmemalloc(xdp));
23752373

2376-
out:
23772374
return skb;
23782375
}
23792376

0 commit comments

Comments
 (0)