Skip to content

Commit eef04c7

Browse files
Boris Ostrovskyjgross1
authored andcommitted
xen: Remove unnecessary BUG_ON from __unbind_from_irq()
Commit 910f8be ("xen/pirq: fix error path cleanup when binding MSIs") fixed a couple of errors in error cleanup path of xen_bind_pirq_msi_to_irq(). This cleanup allowed a call to __unbind_from_irq() with an unbound irq, which would result in triggering the BUG_ON there. Since there is really no reason for the BUG_ON (xen_free_irq() can operate on unbound irqs) we can remove it. Reported-by: Ben Hutchings <[email protected]> Signed-off-by: Boris Ostrovsky <[email protected]> Cc: [email protected] Reviewed-by: Juergen Gross <[email protected]> Signed-off-by: Juergen Gross <[email protected]>
1 parent c51b3c6 commit eef04c7

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

drivers/xen/events/events_base.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -628,8 +628,6 @@ static void __unbind_from_irq(unsigned int irq)
628628
xen_irq_info_cleanup(info);
629629
}
630630

631-
BUG_ON(info_for_irq(irq)->type == IRQT_UNBOUND);
632-
633631
xen_free_irq(irq);
634632
}
635633

0 commit comments

Comments
 (0)