Skip to content

Commit ef6eaf2

Browse files
jandryukJiri Kosina
authored andcommitted
HID: i2c-hid: Fix "incomplete report" noise
Commit ac75a04 ("HID: i2c-hid: fix size check and type usage") started writing messages when the ret_size is <= 2 from i2c_master_recv. However, my device i2c-DLL07D1 returns 2 for a short period of time (~0.5s) after I stop moving the pointing stick or touchpad. It varies, but you get ~50 messages each time which spams the log hard. [ 95.925055] i2c_hid i2c-DLL07D1:01: i2c_hid_get_input: incomplete report (83/2) This has also been observed with a i2c-ALP0017. [ 1781.266353] i2c_hid i2c-ALP0017:00: i2c_hid_get_input: incomplete report (30/2) Only print the message when ret_size is totally invalid and less than 2 to cut down on the log spam. Fixes: ac75a04 ("HID: i2c-hid: fix size check and type usage") Reported-by: John Smith <[email protected]> Cc: [email protected] Signed-off-by: Jason Andryuk <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent 3b8d573 commit ef6eaf2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/hid/i2c-hid/i2c-hid.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@ static void i2c_hid_get_input(struct i2c_hid *ihid)
484484
return;
485485
}
486486

487-
if ((ret_size > size) || (ret_size <= 2)) {
487+
if ((ret_size > size) || (ret_size < 2)) {
488488
dev_err(&ihid->client->dev, "%s: incomplete report (%d/%d)\n",
489489
__func__, size, ret_size);
490490
return;

0 commit comments

Comments
 (0)