Skip to content

Commit ef87f7d

Browse files
grygoriySdavem330
authored andcommitted
net: phy: dp83867: move dt parsing to probe
Move DT parsing code to probe dp83867_probe() as it's one time operation. Signed-off-by: Grygorii Strashko <[email protected]> Reviewed-by: Andrew Lunn <[email protected]> Reviewed-by: Florian Fainelli <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 5a7f08c commit ef87f7d

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

drivers/net/phy/dp83867.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ static int dp83867_probe(struct phy_device *phydev)
299299

300300
phydev->priv = dp83867;
301301

302-
return 0;
302+
return dp83867_of_init(phydev);
303303
}
304304

305305
static int dp83867_config_init(struct phy_device *phydev)
@@ -308,10 +308,6 @@ static int dp83867_config_init(struct phy_device *phydev)
308308
int ret, val, bs;
309309
u16 delay;
310310

311-
ret = dp83867_of_init(phydev);
312-
if (ret)
313-
return ret;
314-
315311
/* RX_DV/RX_CTRL strapped in mode 1 or mode 2 workaround */
316312
if (dp83867->rxctrl_strap_quirk)
317313
phy_clear_bits_mmd(phydev, DP83867_DEVADDR, DP83867_CFG4,

0 commit comments

Comments
 (0)