Skip to content

Commit efa33cd

Browse files
abdelalkuorgregkh
authored andcommitted
USB: typec: tps6598x: Add status trace for tps25750
tps25750 status register is a subset of tps6598x status register, hence a trace for tps25750 status register is added. Signed-off-by: Abdel Alkuor <[email protected]> Reviewed-by: Heikki Krogerus <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent e5d4a41 commit efa33cd

File tree

2 files changed

+38
-0
lines changed

2 files changed

+38
-0
lines changed

drivers/usb/typec/tipd/core.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1412,6 +1412,7 @@ static const struct tipd_data tps25750_data = {
14121412
.irq_handler = tps25750_interrupt,
14131413
.register_port = tps25750_register_port,
14141414
.trace_power_status = trace_tps25750_power_status,
1415+
.trace_status = trace_tps25750_status,
14151416
.apply_patch = tps25750_apply_patch,
14161417
};
14171418

drivers/usb/typec/tipd/trace.h

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,14 @@
9191
TPS_STATUS_USB_HOST_PRESENT_MASK | \
9292
TPS_STATUS_LEGACY_MASK))
9393

94+
#define TPS25750_STATUS_FLAGS_MASK (GENMASK(31, 0) ^ (TPS_STATUS_CONN_STATE_MASK | \
95+
GENMASK(19, 7) | \
96+
TPS_STATUS_VBUS_STATUS_MASK | \
97+
TPS_STATUS_USB_HOST_PRESENT_MASK | \
98+
TPS_STATUS_LEGACY_MASK | \
99+
BIT(26) | \
100+
GENMASK(31, 28)))
101+
94102
#define show_status_conn_state(status) \
95103
__print_symbolic(TPS_STATUS_CONN_STATE((status)), \
96104
{ TPS_STATUS_CONN_STATE_CONN_WITH_R_A, "conn-Ra" }, \
@@ -148,6 +156,14 @@
148156
{ TPS_STATUS_HIGH_VOLAGE_WARNING, "HIGH_VOLAGE_WARNING" }, \
149157
{ TPS_STATUS_HIGH_LOW_VOLTAGE_WARNING, "HIGH_LOW_VOLTAGE_WARNING" })
150158

159+
#define show_tps25750_status_flags(flags) \
160+
__print_flags((flags & TPS25750_STATUS_FLAGS_MASK), "|", \
161+
{ TPS_STATUS_PLUG_PRESENT, "PLUG_PRESENT" }, \
162+
{ TPS_STATUS_PLUG_UPSIDE_DOWN, "UPSIDE_DOWN" }, \
163+
{ TPS_STATUS_PORTROLE, "PORTROLE" }, \
164+
{ TPS_STATUS_DATAROLE, "DATAROLE" }, \
165+
{ TPS_STATUS_BIST, "BIST" })
166+
151167
#define show_power_status_source_sink(power_status) \
152168
__print_symbolic(TPS_POWER_STATUS_SOURCESINK(power_status), \
153169
{ 1, "sink" }, \
@@ -292,6 +308,27 @@ TRACE_EVENT(tps6598x_status,
292308
)
293309
);
294310

311+
TRACE_EVENT(tps25750_status,
312+
TP_PROTO(u32 status),
313+
TP_ARGS(status),
314+
315+
TP_STRUCT__entry(
316+
__field(u32, status)
317+
),
318+
319+
TP_fast_assign(
320+
__entry->status = status;
321+
),
322+
323+
TP_printk("conn: %s, vbus: %s, usb-host: %s, legacy: %s, flags: %s",
324+
show_status_conn_state(__entry->status),
325+
show_status_vbus_status(__entry->status),
326+
show_status_usb_host_present(__entry->status),
327+
show_status_legacy(__entry->status),
328+
show_tps25750_status_flags(__entry->status)
329+
)
330+
);
331+
295332
TRACE_EVENT(tps6598x_power_status,
296333
TP_PROTO(u16 power_status),
297334
TP_ARGS(power_status),

0 commit comments

Comments
 (0)