Skip to content

Commit efe582a

Browse files
committed
Merge tag 'edac_urgent-2020-03-08' of git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras
Pull EDAC fix from Borislav Petkov: "Error reporting fix for synopsys_edac: do not overwrite partial decoded error message (Sherry Sun)" * tag 'edac_urgent-2020-03-08' of git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras: EDAC/synopsys: Do not print an error with back-to-back snprintf() calls
2 parents 378fee2 + dfc6014 commit efe582a

File tree

1 file changed

+7
-15
lines changed

1 file changed

+7
-15
lines changed

drivers/edac/synopsys_edac.c

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -479,20 +479,14 @@ static void handle_error(struct mem_ctl_info *mci, struct synps_ecc_status *p)
479479
pinf = &p->ceinfo;
480480
if (!priv->p_data->quirks) {
481481
snprintf(priv->message, SYNPS_EDAC_MSG_SIZE,
482-
"DDR ECC error type:%s Row %d Bank %d Col %d ",
483-
"CE", pinf->row, pinf->bank, pinf->col);
484-
snprintf(priv->message, SYNPS_EDAC_MSG_SIZE,
485-
"Bit Position: %d Data: 0x%08x\n",
482+
"DDR ECC error type:%s Row %d Bank %d Col %d Bit Position: %d Data: 0x%08x",
483+
"CE", pinf->row, pinf->bank, pinf->col,
486484
pinf->bitpos, pinf->data);
487485
} else {
488486
snprintf(priv->message, SYNPS_EDAC_MSG_SIZE,
489-
"DDR ECC error type:%s Row %d Bank %d Col %d ",
490-
"CE", pinf->row, pinf->bank, pinf->col);
491-
snprintf(priv->message, SYNPS_EDAC_MSG_SIZE,
492-
"BankGroup Number %d Block Number %d ",
493-
pinf->bankgrpnr, pinf->blknr);
494-
snprintf(priv->message, SYNPS_EDAC_MSG_SIZE,
495-
"Bit Position: %d Data: 0x%08x\n",
487+
"DDR ECC error type:%s Row %d Bank %d Col %d BankGroup Number %d Block Number %d Bit Position: %d Data: 0x%08x",
488+
"CE", pinf->row, pinf->bank, pinf->col,
489+
pinf->bankgrpnr, pinf->blknr,
496490
pinf->bitpos, pinf->data);
497491
}
498492

@@ -509,10 +503,8 @@ static void handle_error(struct mem_ctl_info *mci, struct synps_ecc_status *p)
509503
"UE", pinf->row, pinf->bank, pinf->col);
510504
} else {
511505
snprintf(priv->message, SYNPS_EDAC_MSG_SIZE,
512-
"DDR ECC error type :%s Row %d Bank %d Col %d ",
513-
"UE", pinf->row, pinf->bank, pinf->col);
514-
snprintf(priv->message, SYNPS_EDAC_MSG_SIZE,
515-
"BankGroup Number %d Block Number %d",
506+
"DDR ECC error type :%s Row %d Bank %d Col %d BankGroup Number %d Block Number %d",
507+
"UE", pinf->row, pinf->bank, pinf->col,
516508
pinf->bankgrpnr, pinf->blknr);
517509
}
518510

0 commit comments

Comments
 (0)