Skip to content

Commit f00a7c5

Browse files
andy-shevgregkh
authored andcommitted
serial: 8250_lpss: enable MSI for sure
The commit 4fe0d15 ("PCI: Use positive flags in pci_alloc_irq_vectors()") replaces flags from negative to positive values which makes mandatory to have the last argument in pci_alloc_irq_vectors() non-zero (if we want to be no-op). This basically drops MSI enabling in 8250_lpss driver. Restore desired behaviour in 8250_lpss by passing PCI_IRQ_ALL_TYPES instead of 0 to pci_alloc_irq_vectors(). Fixes: 60a9244 ("serial: 8250_lpss: enable MSI for Intel Quark") Cc: Christoph Hellwig <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]> Reviewed-by: Bryan O'Donoghue <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent be2c92b commit f00a7c5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/tty/serial/8250/8250_lpss.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ static int qrk_serial_setup(struct lpss8250 *lpss, struct uart_port *port)
213213
struct pci_dev *pdev = to_pci_dev(port->dev);
214214
int ret;
215215

216-
ret = pci_alloc_irq_vectors(pdev, 1, 1, 0);
216+
ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
217217
if (ret < 0)
218218
return ret;
219219

0 commit comments

Comments
 (0)