Skip to content

Commit f032c53

Browse files
Yujie-Liumhiramat
authored andcommitted
tracing/kprobes: Fix the order of argument descriptions
The order of descriptions should be consistent with the argument list of the function, so "kretprobe" should be the second one. int __kprobe_event_gen_cmd_start(struct dynevent_cmd *cmd, bool kretprobe, const char *name, const char *loc, ...) Link: https://lore.kernel.org/all/[email protected]/ Fixes: 2a588dd ("tracing: Add kprobe event command generation functions") Suggested-by: Mukesh Ojha <[email protected]> Signed-off-by: Yujie Liu <[email protected]> Reviewed-by: Mukesh Ojha <[email protected]> Signed-off-by: Masami Hiramatsu (Google) <[email protected]>
1 parent ce51e61 commit f032c53

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

kernel/trace/trace_kprobe.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1020,9 +1020,9 @@ EXPORT_SYMBOL_GPL(kprobe_event_cmd_init);
10201020
/**
10211021
* __kprobe_event_gen_cmd_start - Generate a kprobe event command from arg list
10221022
* @cmd: A pointer to the dynevent_cmd struct representing the new event
1023+
* @kretprobe: Is this a return probe?
10231024
* @name: The name of the kprobe event
10241025
* @loc: The location of the kprobe event
1025-
* @kretprobe: Is this a return probe?
10261026
* @...: Variable number of arg (pairs), one pair for each field
10271027
*
10281028
* NOTE: Users normally won't want to call this function directly, but

0 commit comments

Comments
 (0)