Skip to content

Commit f03f10a

Browse files
committed
Merge tag 'omap-for-v5.17/fixes-signed' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap into arm/fixes
Fixes for omaps Fixes for devkit8000 timer regression. Similar to the earlier beagleboard fixes, we must not configure the clocksource drivers to use an alternative timer configuration. It causes unnecessary issues with power management. Only some old designs based on early beagleboard revisions with a miswired timer need to use the alternative timer. * tag 'omap-for-v5.17/fixes-signed' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap: ARM: dts: Use 32KiHz oscillator on devkit8000 ARM: dts: switch timer config to common devkit8000 devicetree Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Arnd Bergmann <[email protected]>
2 parents 3f96885 + 8840f54 commit f03f10a

File tree

3 files changed

+19
-35
lines changed

3 files changed

+19
-35
lines changed

arch/arm/boot/dts/omap3-devkit8000-common.dtsi

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,24 @@
158158
status = "disabled";
159159
};
160160

161+
/* Unusable as clockevent because if unreliable oscillator, allow to idle */
162+
&timer1_target {
163+
/delete-property/ti,no-reset-on-init;
164+
/delete-property/ti,no-idle;
165+
timer@0 {
166+
/delete-property/ti,timer-alwon;
167+
};
168+
};
169+
170+
/* Preferred timer for clockevent */
171+
&timer12_target {
172+
ti,no-reset-on-init;
173+
ti,no-idle;
174+
timer@0 {
175+
/* Always clocked by secure_32k_fck */
176+
};
177+
};
178+
161179
&twl_gpio {
162180
ti,use-leds;
163181
/*

arch/arm/boot/dts/omap3-devkit8000.dts

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -14,36 +14,3 @@
1414
display2 = &tv0;
1515
};
1616
};
17-
18-
/* Unusable as clocksource because of unreliable oscillator */
19-
&counter32k {
20-
status = "disabled";
21-
};
22-
23-
/* Unusable as clockevent because if unreliable oscillator, allow to idle */
24-
&timer1_target {
25-
/delete-property/ti,no-reset-on-init;
26-
/delete-property/ti,no-idle;
27-
timer@0 {
28-
/delete-property/ti,timer-alwon;
29-
};
30-
};
31-
32-
/* Preferred always-on timer for clocksource */
33-
&timer12_target {
34-
ti,no-reset-on-init;
35-
ti,no-idle;
36-
timer@0 {
37-
/* Always clocked by secure_32k_fck */
38-
};
39-
};
40-
41-
/* Preferred timer for clockevent */
42-
&timer2_target {
43-
ti,no-reset-on-init;
44-
ti,no-idle;
45-
timer@0 {
46-
assigned-clocks = <&gpt2_fck>;
47-
assigned-clock-parents = <&sys_ck>;
48-
};
49-
};

drivers/clocksource/timer-ti-dm-systimer.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,8 +241,7 @@ static void __init dmtimer_systimer_assign_alwon(void)
241241
bool quirk_unreliable_oscillator = false;
242242

243243
/* Quirk unreliable 32 KiHz oscillator with incomplete dts */
244-
if (of_machine_is_compatible("ti,omap3-beagle-ab4") ||
245-
of_machine_is_compatible("timll,omap3-devkit8000")) {
244+
if (of_machine_is_compatible("ti,omap3-beagle-ab4")) {
246245
quirk_unreliable_oscillator = true;
247246
counter_32k = -ENODEV;
248247
}

0 commit comments

Comments
 (0)