Skip to content

Commit f08aff4

Browse files
Philippe Reynesdavem330
authored andcommitted
net: ethernet: renesas: sh_eth: use new api ethtool_{get|set}_link_ksettings
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes <[email protected]> Tested-by: Simon Horman <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 9fd0375 commit f08aff4

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

drivers/net/ethernet/renesas/sh_eth.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1817,8 +1817,8 @@ static int sh_eth_phy_start(struct net_device *ndev)
18171817
return 0;
18181818
}
18191819

1820-
static int sh_eth_get_settings(struct net_device *ndev,
1821-
struct ethtool_cmd *ecmd)
1820+
static int sh_eth_get_link_ksettings(struct net_device *ndev,
1821+
struct ethtool_link_ksettings *cmd)
18221822
{
18231823
struct sh_eth_private *mdp = netdev_priv(ndev);
18241824
unsigned long flags;
@@ -1828,14 +1828,14 @@ static int sh_eth_get_settings(struct net_device *ndev,
18281828
return -ENODEV;
18291829

18301830
spin_lock_irqsave(&mdp->lock, flags);
1831-
ret = phy_ethtool_gset(ndev->phydev, ecmd);
1831+
ret = phy_ethtool_ksettings_get(ndev->phydev, cmd);
18321832
spin_unlock_irqrestore(&mdp->lock, flags);
18331833

18341834
return ret;
18351835
}
18361836

1837-
static int sh_eth_set_settings(struct net_device *ndev,
1838-
struct ethtool_cmd *ecmd)
1837+
static int sh_eth_set_link_ksettings(struct net_device *ndev,
1838+
const struct ethtool_link_ksettings *cmd)
18391839
{
18401840
struct sh_eth_private *mdp = netdev_priv(ndev);
18411841
unsigned long flags;
@@ -1849,11 +1849,11 @@ static int sh_eth_set_settings(struct net_device *ndev,
18491849
/* disable tx and rx */
18501850
sh_eth_rcv_snd_disable(ndev);
18511851

1852-
ret = phy_ethtool_sset(ndev->phydev, ecmd);
1852+
ret = phy_ethtool_ksettings_set(ndev->phydev, cmd);
18531853
if (ret)
18541854
goto error_exit;
18551855

1856-
if (ecmd->duplex == DUPLEX_FULL)
1856+
if (cmd->base.duplex == DUPLEX_FULL)
18571857
mdp->duplex = 1;
18581858
else
18591859
mdp->duplex = 0;
@@ -2195,8 +2195,6 @@ static int sh_eth_set_ringparam(struct net_device *ndev,
21952195
}
21962196

21972197
static const struct ethtool_ops sh_eth_ethtool_ops = {
2198-
.get_settings = sh_eth_get_settings,
2199-
.set_settings = sh_eth_set_settings,
22002198
.get_regs_len = sh_eth_get_regs_len,
22012199
.get_regs = sh_eth_get_regs,
22022200
.nway_reset = sh_eth_nway_reset,
@@ -2208,6 +2206,8 @@ static const struct ethtool_ops sh_eth_ethtool_ops = {
22082206
.get_sset_count = sh_eth_get_sset_count,
22092207
.get_ringparam = sh_eth_get_ringparam,
22102208
.set_ringparam = sh_eth_set_ringparam,
2209+
.get_link_ksettings = sh_eth_get_link_ksettings,
2210+
.set_link_ksettings = sh_eth_set_link_ksettings,
22112211
};
22122212

22132213
/* network device open function */

0 commit comments

Comments
 (0)