Skip to content

Commit f1267cf

Browse files
Bhagavathi Perumal Sjmberg-intel
authored andcommitted
mac80211: Fix kernel panic due to use of txq after free
The txq of vif is added to active_txqs list for ATF TXQ scheduling in the function ieee80211_queue_skb(), but it was not properly removed before freeing the txq object. It was causing use after free of the txq objects from the active_txqs list, result was kernel panic due to invalid memory access. Fix kernel invalid memory access by properly removing txq object from active_txqs list before free the object. Signed-off-by: Bhagavathi Perumal S <[email protected]> Acked-by: Toke Høiland-Jørgensen <[email protected]> Signed-off-by: Johannes Berg <[email protected]>
1 parent e9f33a8 commit f1267cf

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

net/mac80211/iface.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1908,6 +1908,9 @@ void ieee80211_if_remove(struct ieee80211_sub_if_data *sdata)
19081908
list_del_rcu(&sdata->list);
19091909
mutex_unlock(&sdata->local->iflist_mtx);
19101910

1911+
if (sdata->vif.txq)
1912+
ieee80211_txq_purge(sdata->local, to_txq_info(sdata->vif.txq));
1913+
19111914
synchronize_rcu();
19121915

19131916
if (sdata->dev) {

0 commit comments

Comments
 (0)