Skip to content

Commit f14f368

Browse files
ickledanvet
authored andcommitted
drm/edid: Rename local variable block to edid
The "block" variable points to the entire edid, not individual blocks despite it being named such. Signed-off-by: Chris Wilson <[email protected]> Signed-off-by: Daniel Vetter <[email protected]> Link: http://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent a68362f commit f14f368

File tree

1 file changed

+19
-19
lines changed

1 file changed

+19
-19
lines changed

drivers/gpu/drm/drm_edid.c

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1282,20 +1282,20 @@ struct edid *drm_do_get_edid(struct drm_connector *connector,
12821282
void *data)
12831283
{
12841284
int i, j = 0, valid_extensions = 0;
1285-
u8 *block, *new;
1285+
u8 *edid, *new;
12861286
bool print_bad_edid = !connector->bad_edid_counter || (drm_debug & DRM_UT_KMS);
12871287

1288-
if ((block = kmalloc(EDID_LENGTH, GFP_KERNEL)) == NULL)
1288+
if ((edid = kmalloc(EDID_LENGTH, GFP_KERNEL)) == NULL)
12891289
return NULL;
12901290

12911291
/* base block fetch */
12921292
for (i = 0; i < 4; i++) {
1293-
if (get_edid_block(data, block, 0, EDID_LENGTH))
1293+
if (get_edid_block(data, edid, 0, EDID_LENGTH))
12941294
goto out;
1295-
if (drm_edid_block_valid(block, 0, print_bad_edid,
1295+
if (drm_edid_block_valid(edid, 0, print_bad_edid,
12961296
&connector->edid_corrupt))
12971297
break;
1298-
if (i == 0 && drm_edid_is_zero(block, EDID_LENGTH)) {
1298+
if (i == 0 && drm_edid_is_zero(edid, EDID_LENGTH)) {
12991299
connector->null_edid_counter++;
13001300
goto carp;
13011301
}
@@ -1304,21 +1304,21 @@ struct edid *drm_do_get_edid(struct drm_connector *connector,
13041304
goto carp;
13051305

13061306
/* if there's no extensions, we're done */
1307-
if (block[0x7e] == 0)
1308-
return (struct edid *)block;
1307+
if (edid[0x7e] == 0)
1308+
return (struct edid *)edid;
13091309

1310-
new = krealloc(block, (block[0x7e] + 1) * EDID_LENGTH, GFP_KERNEL);
1310+
new = krealloc(edid, (edid[0x7e] + 1) * EDID_LENGTH, GFP_KERNEL);
13111311
if (!new)
13121312
goto out;
1313-
block = new;
1313+
edid = new;
13141314

1315-
for (j = 1; j <= block[0x7e]; j++) {
1315+
for (j = 1; j <= edid[0x7e]; j++) {
13161316
for (i = 0; i < 4; i++) {
13171317
if (get_edid_block(data,
1318-
block + (valid_extensions + 1) * EDID_LENGTH,
1318+
edid + (valid_extensions + 1) * EDID_LENGTH,
13191319
j, EDID_LENGTH))
13201320
goto out;
1321-
if (drm_edid_block_valid(block + (valid_extensions + 1)
1321+
if (drm_edid_block_valid(edid + (valid_extensions + 1)
13221322
* EDID_LENGTH, j,
13231323
print_bad_edid,
13241324
NULL)) {
@@ -1336,16 +1336,16 @@ struct edid *drm_do_get_edid(struct drm_connector *connector,
13361336
}
13371337
}
13381338

1339-
if (valid_extensions != block[0x7e]) {
1340-
block[EDID_LENGTH-1] += block[0x7e] - valid_extensions;
1341-
block[0x7e] = valid_extensions;
1342-
new = krealloc(block, (valid_extensions + 1) * EDID_LENGTH, GFP_KERNEL);
1339+
if (valid_extensions != edid[0x7e]) {
1340+
edid[EDID_LENGTH-1] += edid[0x7e] - valid_extensions;
1341+
edid[0x7e] = valid_extensions;
1342+
new = krealloc(edid, (valid_extensions + 1) * EDID_LENGTH, GFP_KERNEL);
13431343
if (!new)
13441344
goto out;
1345-
block = new;
1345+
edid = new;
13461346
}
13471347

1348-
return (struct edid *)block;
1348+
return (struct edid *)edid;
13491349

13501350
carp:
13511351
if (print_bad_edid) {
@@ -1355,7 +1355,7 @@ struct edid *drm_do_get_edid(struct drm_connector *connector,
13551355
connector->bad_edid_counter++;
13561356

13571357
out:
1358-
kfree(block);
1358+
kfree(edid);
13591359
return NULL;
13601360
}
13611361
EXPORT_SYMBOL_GPL(drm_do_get_edid);

0 commit comments

Comments
 (0)