Skip to content

Commit f160238

Browse files
jhovoldgregkh
authored andcommitted
staging: greybus: loopback_test: fix potential path truncation
Newer GCC warns about a possible truncation of a generated sysfs path name as we're concatenating a directory path with a file name and placing the result in a buffer that is half the size of the maximum length of the directory path (which is user controlled). loopback_test.c: In function 'open_poll_files': loopback_test.c:651:31: warning: '%s' directive output may be truncated writing up to 511 bytes into a region of size 255 [-Wformat-truncation=] 651 | snprintf(buf, sizeof(buf), "%s%s", dev->sysfs_entry, "iteration_count"); | ^~ loopback_test.c:651:3: note: 'snprintf' output between 16 and 527 bytes into a destination of size 255 651 | snprintf(buf, sizeof(buf), "%s%s", dev->sysfs_entry, "iteration_count"); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fix this by making sure the buffer is large enough the concatenated strings. Fixes: 6b0658f ("greybus: tools: Add tools directory to greybus repo and add loopback") Fixes: 9250c0e ("greybus: Loopback_test: use poll instead of inotify") Signed-off-by: Johan Hovold <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 8f3675b commit f160238

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/staging/greybus/tools/loopback_test.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -637,7 +637,7 @@ int find_loopback_devices(struct loopback_test *t)
637637
static int open_poll_files(struct loopback_test *t)
638638
{
639639
struct loopback_device *dev;
640-
char buf[MAX_STR_LEN];
640+
char buf[MAX_SYSFS_PATH + MAX_STR_LEN];
641641
char dummy;
642642
int fds_idx = 0;
643643
int i;

0 commit comments

Comments
 (0)