Skip to content

Commit f2d1421

Browse files
author
Christoph Hellwig
committed
nvmet: set the LBCC bit for commands that modify data
Write, Write Zeroes, Zone append and a Zone Reset through Zone Management Send modify the logical block content of a namespace, so make sure the LBCC bit is reported for them. Fixes: b5d0b38c0475 ("nvmet: add Command Set Identifier support") Signed-off-by: Christoph Hellwig <[email protected]> Reviewed-by: Keith Busch <[email protected]> Reviewed-by: Sagi Grimberg <[email protected]> Reviewed-by: Kanchan Joshi <[email protected]> Reviewed-by: Chaitanya Kulkarni <[email protected]>
1 parent 61f3715 commit f2d1421

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/nvme/target/admin-cmd.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,17 +174,19 @@ static void nvmet_get_cmd_effects_nvm(struct nvme_effects_log *log)
174174
cpu_to_le32(NVME_CMD_EFFECTS_CSUPP);
175175

176176
log->iocs[nvme_cmd_read] =
177-
log->iocs[nvme_cmd_write] =
178177
log->iocs[nvme_cmd_flush] =
179178
log->iocs[nvme_cmd_dsm] =
180-
log->iocs[nvme_cmd_write_zeroes] =
181179
cpu_to_le32(NVME_CMD_EFFECTS_CSUPP);
180+
log->iocs[nvme_cmd_write] =
181+
log->iocs[nvme_cmd_write_zeroes] =
182+
cpu_to_le32(NVME_CMD_EFFECTS_CSUPP | NVME_CMD_EFFECTS_LBCC);
182183
}
183184

184185
static void nvmet_get_cmd_effects_zns(struct nvme_effects_log *log)
185186
{
186187
log->iocs[nvme_cmd_zone_append] =
187188
log->iocs[nvme_cmd_zone_mgmt_send] =
189+
cpu_to_le32(NVME_CMD_EFFECTS_CSUPP | NVME_CMD_EFFECTS_LBCC);
188190
log->iocs[nvme_cmd_zone_mgmt_recv] =
189191
cpu_to_le32(NVME_CMD_EFFECTS_CSUPP);
190192
}

0 commit comments

Comments
 (0)