Skip to content

Commit f3637a5

Browse files
Sebastian Andrzej SiewiorKAGA-KOKO
authored andcommitted
irq: Always set IRQF_ONESHOT if no primary handler is specified
If no primary handler is specified then a default one is assigned which always returns IRQ_WAKE_THREAD. This handler requires the IRQF_ONESHOT flag on LEVEL / EIO typed irqs because the source of interrupt is not disabled. Since it is required for those users and there is no difference for others it makes sense to add this flag unconditionally. Signed-off-by: Sebastian Andrzej Siewior <[email protected]> Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Thomas Gleixner <[email protected]>
1 parent 1dd75f9 commit f3637a5

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

kernel/irq/manage.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1322,6 +1322,7 @@ int request_threaded_irq(unsigned int irq, irq_handler_t handler,
13221322
if (!thread_fn)
13231323
return -EINVAL;
13241324
handler = irq_default_primary_handler;
1325+
irqflags |= IRQF_ONESHOT;
13251326
}
13261327

13271328
action = kzalloc(sizeof(struct irqaction), GFP_KERNEL);

0 commit comments

Comments
 (0)