Skip to content

Commit f4268a4

Browse files
author
Thomas Zimmermann
committed
drm/qxl: Use drm_gem_ttm_dumb_map_offset()
Qxl now uses drm_gem_ttm_dumb_map_offset() to implement struct drm_driver.dumb_map_offset. Signed-off-by: Thomas Zimmermann <[email protected]> Acked-by: Maxime Ripard <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 4c398f5 commit f4268a4

File tree

5 files changed

+4
-28
lines changed

5 files changed

+4
-28
lines changed

drivers/gpu/drm/qxl/qxl_drv.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
#include <drm/drm_atomic_helper.h>
3838
#include <drm/drm_drv.h>
3939
#include <drm/drm_file.h>
40+
#include <drm/drm_gem_ttm_helper.h>
4041
#include <drm/drm_modeset_helper.h>
4142
#include <drm/drm_prime.h>
4243
#include <drm/drm_probe_helper.h>
@@ -271,7 +272,7 @@ static struct drm_driver qxl_driver = {
271272
.driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
272273

273274
.dumb_create = qxl_mode_dumb_create,
274-
.dumb_map_offset = qxl_mode_dumb_mmap,
275+
.dumb_map_offset = drm_gem_ttm_dumb_map_offset,
275276
#if defined(CONFIG_DEBUG_FS)
276277
.debugfs_init = qxl_debugfs_init,
277278
#endif

drivers/gpu/drm/qxl/qxl_drv.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -330,9 +330,6 @@ void qxl_bo_force_delete(struct qxl_device *qdev);
330330
int qxl_mode_dumb_create(struct drm_file *file_priv,
331331
struct drm_device *dev,
332332
struct drm_mode_create_dumb *args);
333-
int qxl_mode_dumb_mmap(struct drm_file *filp,
334-
struct drm_device *dev,
335-
uint32_t handle, uint64_t *offset_p);
336333

337334
/* qxl ttm */
338335
int qxl_ttm_init(struct qxl_device *qdev);

drivers/gpu/drm/qxl/qxl_dumb.c

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -69,20 +69,3 @@ int qxl_mode_dumb_create(struct drm_file *file_priv,
6969
args->handle = handle;
7070
return 0;
7171
}
72-
73-
int qxl_mode_dumb_mmap(struct drm_file *file_priv,
74-
struct drm_device *dev,
75-
uint32_t handle, uint64_t *offset_p)
76-
{
77-
struct drm_gem_object *gobj;
78-
struct qxl_bo *qobj;
79-
80-
BUG_ON(!offset_p);
81-
gobj = drm_gem_object_lookup(file_priv, handle);
82-
if (gobj == NULL)
83-
return -ENOENT;
84-
qobj = gem_to_qxl_bo(gobj);
85-
*offset_p = qxl_bo_mmap_offset(qobj);
86-
drm_gem_object_put(gobj);
87-
return 0;
88-
}

drivers/gpu/drm/qxl/qxl_ioctl.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ static int qxl_map_ioctl(struct drm_device *dev, void *data,
6767
struct qxl_device *qdev = to_qxl(dev);
6868
struct drm_qxl_map *qxl_map = data;
6969

70-
return qxl_mode_dumb_mmap(file_priv, &qdev->ddev, qxl_map->handle,
71-
&qxl_map->offset);
70+
return drm_gem_ttm_dumb_map_offset(file_priv, &qdev->ddev, qxl_map->handle,
71+
&qxl_map->offset);
7272
}
7373

7474
struct qxl_reloc_info {

drivers/gpu/drm/qxl/qxl_object.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,6 @@ static inline unsigned long qxl_bo_size(struct qxl_bo *bo)
5353
return bo->tbo.base.size;
5454
}
5555

56-
static inline u64 qxl_bo_mmap_offset(struct qxl_bo *bo)
57-
{
58-
return drm_vma_node_offset_addr(&bo->tbo.base.vma_node);
59-
}
60-
6156
extern int qxl_bo_create(struct qxl_device *qdev,
6257
unsigned long size,
6358
bool kernel, bool pinned, u32 domain,

0 commit comments

Comments
 (0)