Skip to content

Commit f4353da

Browse files
Andri Yngvasonmarckleinebudde
authored andcommitted
can: cc770: Fix stalls on rt-linux, remove redundant IRQ ack
This has been reported to cause stalls on rt-linux. Suggested-by: Richard Weinberger <[email protected]> Tested-by: Richard Weinberger <[email protected]> Signed-off-by: Andri Yngvason <[email protected]> Cc: linux-stable <[email protected]> Signed-off-by: Marc Kleine-Budde <[email protected]>
1 parent f89782c commit f4353da

File tree

1 file changed

+0
-15
lines changed

1 file changed

+0
-15
lines changed

drivers/net/can/cc770/cc770.c

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -447,15 +447,6 @@ static netdev_tx_t cc770_start_xmit(struct sk_buff *skb, struct net_device *dev)
447447

448448
stats->tx_bytes += dlc;
449449

450-
451-
/*
452-
* HM: We had some cases of repeated IRQs so make sure the
453-
* INT is acknowledged I know it's already further up, but
454-
* doing again fixed the issue
455-
*/
456-
cc770_write_reg(priv, msgobj[mo].ctrl0,
457-
MSGVAL_UNC | TXIE_UNC | RXIE_UNC | INTPND_RES);
458-
459450
return NETDEV_TX_OK;
460451
}
461452

@@ -684,12 +675,6 @@ static void cc770_tx_interrupt(struct net_device *dev, unsigned int o)
684675
/* Nothing more to send, switch off interrupts */
685676
cc770_write_reg(priv, msgobj[mo].ctrl0,
686677
MSGVAL_RES | TXIE_RES | RXIE_RES | INTPND_RES);
687-
/*
688-
* We had some cases of repeated IRQ so make sure the
689-
* INT is acknowledged
690-
*/
691-
cc770_write_reg(priv, msgobj[mo].ctrl0,
692-
MSGVAL_UNC | TXIE_UNC | RXIE_UNC | INTPND_RES);
693678

694679
stats->tx_packets++;
695680
can_get_echo_skb(dev, 0);

0 commit comments

Comments
 (0)