mt76: mt7915: fix endian bug in mt7915_rf_regval_set()

Dan Carpenter · nbd168 · commit f572dc969a59 · 2022-07-11T13:40:00.000+02:00
This code is supposed to set a u32 value, but casting will not work on big endian systems. Fixes: 0a17329 ("mt76: mt7915: add debugfs knob for RF registers read/write") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Felix Fietkau <nbd@nbd.name>
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
@@ -985,8 +985,9 @@ static int
 mt7915_rf_regval_set(void *data, u64 val)
 {
 	struct mt7915_dev *dev = data;
+	u32 val32 = val;
 
-	return mt7915_mcu_rf_regval(dev, dev->mt76.debugfs_reg, (u32 *)&val, true);
+	return mt7915_mcu_rf_regval(dev, dev->mt76.debugfs_reg, &val32, true);
 }
 
 DEFINE_DEBUGFS_ATTRIBUTE(fops_rf_regval, mt7915_rf_regval_get,

Original file line number	Diff line number	Diff line change
`@@ -985,8 +985,9 @@ static int`
`985`	`985`	`mt7915_rf_regval_set(void *data, u64 val)`
`986`	`986`	`{`
`987`	`987`	`struct mt7915_dev *dev = data;`
	`988`	`+ u32 val32 = val;`
`988`	`989`
`989`		`- return mt7915_mcu_rf_regval(dev, dev->mt76.debugfs_reg, (u32 *)&val, true);`
	`990`	`+ return mt7915_mcu_rf_regval(dev, dev->mt76.debugfs_reg, &val32, true);`
`990`	`991`	`}`
`991`	`992`
`992`	`993`	`DEFINE_DEBUGFS_ATTRIBUTE(fops_rf_regval, mt7915_rf_regval_get,`