net: b44: remove redundant assignment to variable reg

Colin Ian King · davem330 · commit f58a887ebc99 · 2019-10-15T12:57:55.000-04:00
The variable reg is being assigned a value that is never read
and is being re-assigned in the following for-loop. The
assignment is redundant and hence can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c
@@ -511,9 +511,6 @@ static void b44_stats_update(struct b44 *bp)
 		*val++ += br32(bp, reg);
 	}
 
-	/* Pad */
-	reg += 8*4UL;
-
 	for (reg = B44_RX_GOOD_O; reg <= B44_RX_NPAUSE; reg += 4UL) {
 		*val++ += br32(bp, reg);
 	}

Original file line number	Diff line number	Diff line change
`@@ -511,9 +511,6 @@ static void b44_stats_update(struct b44 *bp)`
`511`	`511`	`*val++ += br32(bp, reg);`
`512`	`512`	`}`
`513`	`513`
`514`		`- /* Pad */`
`515`		`- reg += 8*4UL;`
`516`		`-`
`517`	`514`	`for (reg = B44_RX_GOOD_O; reg <= B44_RX_NPAUSE; reg += 4UL) {`
`518`	`515`	`*val++ += br32(bp, reg);`
`519`	`516`	`}`