Skip to content

Commit f5e39b5

Browse files
longlimsftkuba-moo
authored andcommitted
net: mana: Use the correct WQE count for ringing RQ doorbell
The hardware specification specifies that WQE_COUNT should set to 0 for the Receive Queue. Although currently the hardware doesn't enforce the check, in the future releases it may check on this value. Reviewed-by: Haiyang Zhang <[email protected]> Reviewed-by: Dexuan Cui <[email protected]> Signed-off-by: Long Li <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent da4e864 commit f5e39b5

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/net/ethernet/microsoft/mana/gdma_main.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,8 +300,11 @@ static void mana_gd_ring_doorbell(struct gdma_context *gc, u32 db_index,
300300

301301
void mana_gd_wq_ring_doorbell(struct gdma_context *gc, struct gdma_queue *queue)
302302
{
303+
/* Hardware Spec specifies that software client should set 0 for
304+
* wqe_cnt for Receive Queues. This value is not used in Send Queues.
305+
*/
303306
mana_gd_ring_doorbell(gc, queue->gdma_dev->doorbell, queue->type,
304-
queue->id, queue->head * GDMA_WQE_BU_SIZE, 1);
307+
queue->id, queue->head * GDMA_WQE_BU_SIZE, 0);
305308
}
306309

307310
void mana_gd_ring_cq(struct gdma_queue *cq, u8 arm_bit)

0 commit comments

Comments
 (0)