[fix] lustre: d_make_root() does iput() on dentry allocation failure

Al Viro · Al Viro · commit f77ced6637a1 · 2014-09-13T22:13:39.000-04:00
double-free is a bad thing

Signed-off-by: Al Viro &lt;viro@zeniv.linux.org.uk&gt;
diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c b/drivers/staging/lustre/lustre/llite/llite_lib.c
@@ -568,7 +568,7 @@ static int client_common_fill_super(struct super_block *sb, char *md, char *dt,
 	if (sb->s_root == NULL) {
 		CERROR("%s: can't make root dentry\n",
 			ll_get_fsname(sb, NULL, 0));
-		GOTO(out_root, err = -ENOMEM);
+		GOTO(out_lock_cn_cb, err = -ENOMEM);
 	}
 
 	sbi->ll_sdev_orig = sb->s_dev;

Original file line number	Diff line number	Diff line change
`@@ -568,7 +568,7 @@ static int client_common_fill_super(struct super_block sb, char md, char *dt,`
`568`	`568`	`if (sb->s_root == NULL) {`
`569`	`569`	`CERROR("%s: can't make root dentry\n",`
`570`	`570`	`ll_get_fsname(sb, NULL, 0));`
`571`		`- GOTO(out_root, err = -ENOMEM);`
	`571`	`+ GOTO(out_lock_cn_cb, err = -ENOMEM);`
`572`	`572`	`}`
`573`	`573`
`574`	`574`	`sbi->ll_sdev_orig = sb->s_dev;`