Skip to content

Commit f78a03f

Browse files
hygonitehcaster
authored andcommitted
mm/slab_common: remove CONFIG_NUMA ifdefs for common kmalloc functions
Now that slab_alloc_node() is available for SLAB when CONFIG_NUMA=n, remove CONFIG_NUMA ifdefs for common kmalloc functions. Signed-off-by: Hyeonggon Yoo <[email protected]> Reviewed-by: Vlastimil Babka <[email protected]> Signed-off-by: Vlastimil Babka <[email protected]>
1 parent 07588d7 commit f78a03f

File tree

4 files changed

+1
-40
lines changed

4 files changed

+1
-40
lines changed

include/linux/slab.h

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -456,38 +456,18 @@ static __always_inline void kfree_bulk(size_t size, void **p)
456456
kmem_cache_free_bulk(NULL, size, p);
457457
}
458458

459-
#ifdef CONFIG_NUMA
460459
void *__kmalloc_node(size_t size, gfp_t flags, int node) __assume_kmalloc_alignment
461460
__alloc_size(1);
462461
void *kmem_cache_alloc_node(struct kmem_cache *s, gfp_t flags, int node) __assume_slab_alignment
463462
__malloc;
464-
#else
465-
static __always_inline __alloc_size(1) void *__kmalloc_node(size_t size, gfp_t flags, int node)
466-
{
467-
return __kmalloc(size, flags);
468-
}
469-
470-
static __always_inline void *kmem_cache_alloc_node(struct kmem_cache *s, gfp_t flags, int node)
471-
{
472-
return kmem_cache_alloc(s, flags);
473-
}
474-
#endif
475463

476464
#ifdef CONFIG_TRACING
477465
extern void *kmem_cache_alloc_trace(struct kmem_cache *s, gfp_t flags, size_t size)
478466
__assume_slab_alignment __alloc_size(3);
479467

480-
#ifdef CONFIG_NUMA
481468
extern void *kmem_cache_alloc_node_trace(struct kmem_cache *s, gfp_t gfpflags,
482469
int node, size_t size) __assume_slab_alignment
483470
__alloc_size(4);
484-
#else
485-
static __always_inline __alloc_size(4) void *kmem_cache_alloc_node_trace(struct kmem_cache *s,
486-
gfp_t gfpflags, int node, size_t size)
487-
{
488-
return kmem_cache_alloc_trace(s, gfpflags, size);
489-
}
490-
#endif /* CONFIG_NUMA */
491471

492472
#else /* CONFIG_TRACING */
493473
static __always_inline __alloc_size(3) void *kmem_cache_alloc_trace(struct kmem_cache *s,
@@ -701,20 +681,12 @@ static inline __alloc_size(1, 2) void *kcalloc_node(size_t n, size_t size, gfp_t
701681
}
702682

703683

704-
#ifdef CONFIG_NUMA
705684
extern void *__kmalloc_node_track_caller(size_t size, gfp_t flags, int node,
706685
unsigned long caller) __alloc_size(1);
707686
#define kmalloc_node_track_caller(size, flags, node) \
708687
__kmalloc_node_track_caller(size, flags, node, \
709688
_RET_IP_)
710689

711-
#else /* CONFIG_NUMA */
712-
713-
#define kmalloc_node_track_caller(size, flags, node) \
714-
kmalloc_track_caller(size, flags)
715-
716-
#endif /* CONFIG_NUMA */
717-
718690
/*
719691
* Shortcuts
720692
*/

mm/slab.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3535,7 +3535,6 @@ kmem_cache_alloc_trace(struct kmem_cache *cachep, gfp_t flags, size_t size)
35353535
EXPORT_SYMBOL(kmem_cache_alloc_trace);
35363536
#endif
35373537

3538-
#ifdef CONFIG_NUMA
35393538
/**
35403539
* kmem_cache_alloc_node - Allocate an object on the specified node
35413540
* @cachep: The cache to allocate from.
@@ -3609,7 +3608,6 @@ void *__kmalloc_node_track_caller(size_t size, gfp_t flags,
36093608
return __do_kmalloc_node(size, flags, node, caller);
36103609
}
36113610
EXPORT_SYMBOL(__kmalloc_node_track_caller);
3612-
#endif /* CONFIG_NUMA */
36133611

36143612
#ifdef CONFIG_PRINTK
36153613
void __kmem_obj_info(struct kmem_obj_info *kpp, void *object, struct slab *slab)

mm/slob.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -536,14 +536,12 @@ void *__kmalloc_track_caller(size_t size, gfp_t gfp, unsigned long caller)
536536
}
537537
EXPORT_SYMBOL(__kmalloc_track_caller);
538538

539-
#ifdef CONFIG_NUMA
540539
void *__kmalloc_node_track_caller(size_t size, gfp_t gfp,
541540
int node, unsigned long caller)
542541
{
543542
return __do_kmalloc_node(size, gfp, node, caller);
544543
}
545544
EXPORT_SYMBOL(__kmalloc_node_track_caller);
546-
#endif
547545

548546
void kfree(const void *block)
549547
{
@@ -647,7 +645,7 @@ void *kmem_cache_alloc_lru(struct kmem_cache *cachep, struct list_lru *lru, gfp_
647645
return slob_alloc_node(cachep, flags, NUMA_NO_NODE);
648646
}
649647
EXPORT_SYMBOL(kmem_cache_alloc_lru);
650-
#ifdef CONFIG_NUMA
648+
651649
void *__kmalloc_node(size_t size, gfp_t gfp, int node)
652650
{
653651
return __do_kmalloc_node(size, gfp, node, _RET_IP_);
@@ -659,7 +657,6 @@ void *kmem_cache_alloc_node(struct kmem_cache *cachep, gfp_t gfp, int node)
659657
return slob_alloc_node(cachep, gfp, node);
660658
}
661659
EXPORT_SYMBOL(kmem_cache_alloc_node);
662-
#endif
663660

664661
static void __kmem_cache_free(void *b, int size)
665662
{

mm/slub.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3287,7 +3287,6 @@ void *kmem_cache_alloc_trace(struct kmem_cache *s, gfp_t gfpflags, size_t size)
32873287
EXPORT_SYMBOL(kmem_cache_alloc_trace);
32883288
#endif
32893289

3290-
#ifdef CONFIG_NUMA
32913290
void *kmem_cache_alloc_node(struct kmem_cache *s, gfp_t gfpflags, int node)
32923291
{
32933292
void *ret = slab_alloc_node(s, NULL, gfpflags, node, _RET_IP_, s->object_size);
@@ -3314,7 +3313,6 @@ void *kmem_cache_alloc_node_trace(struct kmem_cache *s,
33143313
}
33153314
EXPORT_SYMBOL(kmem_cache_alloc_node_trace);
33163315
#endif
3317-
#endif /* CONFIG_NUMA */
33183316

33193317
/*
33203318
* Slow path handling. This may still be called frequently since objects
@@ -4427,7 +4425,6 @@ void *__kmalloc(size_t size, gfp_t flags)
44274425
}
44284426
EXPORT_SYMBOL(__kmalloc);
44294427

4430-
#ifdef CONFIG_NUMA
44314428
static void *kmalloc_large_node(size_t size, gfp_t flags, int node)
44324429
{
44334430
struct page *page;
@@ -4474,7 +4471,6 @@ void *__kmalloc_node(size_t size, gfp_t flags, int node)
44744471
return ret;
44754472
}
44764473
EXPORT_SYMBOL(__kmalloc_node);
4477-
#endif /* CONFIG_NUMA */
44784474

44794475
#ifdef CONFIG_HARDENED_USERCOPY
44804476
/*
@@ -4930,7 +4926,6 @@ void *__kmalloc_track_caller(size_t size, gfp_t gfpflags, unsigned long caller)
49304926
}
49314927
EXPORT_SYMBOL(__kmalloc_track_caller);
49324928

4933-
#ifdef CONFIG_NUMA
49344929
void *__kmalloc_node_track_caller(size_t size, gfp_t gfpflags,
49354930
int node, unsigned long caller)
49364931
{
@@ -4960,7 +4955,6 @@ void *__kmalloc_node_track_caller(size_t size, gfp_t gfpflags,
49604955
return ret;
49614956
}
49624957
EXPORT_SYMBOL(__kmalloc_node_track_caller);
4963-
#endif
49644958

49654959
#ifdef CONFIG_SYSFS
49664960
static int count_inuse(struct slab *slab)

0 commit comments

Comments
 (0)