Skip to content

Commit f7f56d5

Browse files
Uwe Kleine-KönigKAGA-KOKO
authored andcommitted
irqchip/ts4800: Convert to platform_driver::remove_new() callback
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <[email protected]> Signed-off-by: Thomas Gleixner <[email protected]> Link: https://lore.kernel.org/r/0bdce86b50e5aa50cffbc4add332cbfbad87521e.1703284359.git.u.kleine-koenig@pengutronix.de
1 parent 935603e commit f7f56d5

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

drivers/irqchip/irq-ts4800.c

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -139,13 +139,11 @@ static int ts4800_ic_probe(struct platform_device *pdev)
139139
return 0;
140140
}
141141

142-
static int ts4800_ic_remove(struct platform_device *pdev)
142+
static void ts4800_ic_remove(struct platform_device *pdev)
143143
{
144144
struct ts4800_irq_data *data = platform_get_drvdata(pdev);
145145

146146
irq_domain_remove(data->domain);
147-
148-
return 0;
149147
}
150148

151149
static const struct of_device_id ts4800_ic_of_match[] = {
@@ -155,11 +153,11 @@ static const struct of_device_id ts4800_ic_of_match[] = {
155153
MODULE_DEVICE_TABLE(of, ts4800_ic_of_match);
156154

157155
static struct platform_driver ts4800_ic_driver = {
158-
.probe = ts4800_ic_probe,
159-
.remove = ts4800_ic_remove,
156+
.probe = ts4800_ic_probe,
157+
.remove_new = ts4800_ic_remove,
160158
.driver = {
161-
.name = "ts4800-irqc",
162-
.of_match_table = ts4800_ic_of_match,
159+
.name = "ts4800-irqc",
160+
.of_match_table = ts4800_ic_of_match,
163161
},
164162
};
165163
module_platform_driver(ts4800_ic_driver);

0 commit comments

Comments
 (0)