Skip to content

Commit f84fdf8

Browse files
committed
kbuild: remove the owner check in mkcompile_h
This reverts a very old commit, which dates back to the pre-git era: |commit 5d1cfb5b12f72145d30ba0f53c9f238144b122b8 |Author: Kai Germaschewski <[email protected]> |Date: Sat Jul 27 02:53:19 2002 -0500 | | kbuild: Fix compiling/installing as different users | | "make bzImage && sudo make install" had the problem that during | the "sudo make install" the build system would notice that the information | in include/linux/compile.h is not accurate (it says "compiled by <user>", | but we are root), thus causing compile.h to be updated and leading to | some recompiles. | | We now only update "compile.h" if the current user is the owner of | include/linux/autoconf.h, i.e. the user who did the "make *config". So the | above sequence will correctly state "compiled by <user>". | |diff --git a/scripts/mkcompile_h b/scripts/mkcompile_h |index 6313db96172..cd956380978 100755 |--- a/scripts/mkcompile_h |+++ b/scripts/mkcompile_h |@@ -3,6 +3,17 @@ ARCH=$2 | SMP=$3 | CC=$4 | |+# If compile.h exists already and we don't own autoconf.h |+# (i.e. we're not the same user who did make *config), don't |+# modify compile.h |+# So "sudo make install" won't change the "compiled by <user>" |+# do "compiled by root" |+ |+if [ -r $TARGET -a ! -O ../include/linux/autoconf.h ]; then |+ echo ' (not modified)' |+ exit 0 |+fi |+ | if [ -r ../.version ]; then | VERSION=`cat ../.version` | else The 'make bzImage && sudo make install' problem no longer happens because commit 1648e4f ("x86, kbuild: make "make install" not depend on vmlinux") fixed the root cause. Commit 19514fc ("arm, kbuild: make "make install" not depend on vmlinux") fixed the similar issue on ARM, with detailed explanation. So, the rule is that the installation targets should never trigger the builds of any build artifact. By following it, this check is unneeded. Signed-off-by: Masahiro Yamada <[email protected]>
1 parent 98d54f8 commit f84fdf8

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

scripts/mkcompile_h

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,6 @@ CC=$6
1010

1111
vecho() { [ "${quiet}" = "silent_" ] || echo "$@" ; }
1212

13-
# If compile.h exists already and we don't own autoconf.h
14-
# (i.e. we're not the same user who did make *config), don't
15-
# modify compile.h
16-
# So "sudo make install" won't change the "compiled by <user>"
17-
# do "compiled by root"
18-
19-
if [ -r $TARGET -a ! -O include/generated/autoconf.h ]; then
20-
vecho " SKIPPED $TARGET"
21-
exit 0
22-
fi
23-
2413
# Do not expand names
2514
set -f
2615

0 commit comments

Comments
 (0)