Skip to content

Commit f8c7e4e

Browse files
committed
Merge tag 'pci-v5.17-fixes-2' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci
Pull pci fixes from Bjorn Helgaas: - Fix compilation warnings in new mt7621 driver (Sergio Paracuellos) - Restore the sysfs "rom" file for VGA shadow ROMs, which was broken when converting "rom" to be a static attribute (Bjorn Helgaas) * tag 'pci-v5.17-fixes-2' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci: PCI/sysfs: Find shadow ROM before static attribute initialization PCI: mt7621: Remove unused function pcie_rmw() PCI: mt7621: Drop of_match_ptr() to avoid unused variable
2 parents 4cd9008 + 66d28b2 commit f8c7e4e

File tree

4 files changed

+9
-19
lines changed

4 files changed

+9
-19
lines changed

arch/ia64/pci/fixup.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,5 +76,5 @@ static void pci_fixup_video(struct pci_dev *pdev)
7676
}
7777
}
7878
}
79-
DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_ANY_ID, PCI_ANY_ID,
80-
PCI_CLASS_DISPLAY_VGA, 8, pci_fixup_video);
79+
DECLARE_PCI_FIXUP_CLASS_HEADER(PCI_ANY_ID, PCI_ANY_ID,
80+
PCI_CLASS_DISPLAY_VGA, 8, pci_fixup_video);

arch/mips/loongson64/vbios_quirk.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
#include <linux/pci.h>
44
#include <loongson.h>
55

6-
static void pci_fixup_radeon(struct pci_dev *pdev)
6+
static void pci_fixup_video(struct pci_dev *pdev)
77
{
88
struct resource *res = &pdev->resource[PCI_ROM_RESOURCE];
99

@@ -22,8 +22,7 @@ static void pci_fixup_radeon(struct pci_dev *pdev)
2222
res->flags = IORESOURCE_MEM | IORESOURCE_ROM_SHADOW |
2323
IORESOURCE_PCI_FIXED;
2424

25-
dev_info(&pdev->dev, "BAR %d: assigned %pR for Radeon ROM\n",
26-
PCI_ROM_RESOURCE, res);
25+
dev_info(&pdev->dev, "Video device with shadowed ROM at %pR\n", res);
2726
}
28-
DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_ATI, 0x9615,
29-
PCI_CLASS_DISPLAY_VGA, 8, pci_fixup_radeon);
27+
DECLARE_PCI_FIXUP_CLASS_HEADER(PCI_VENDOR_ID_ATI, 0x9615,
28+
PCI_CLASS_DISPLAY_VGA, 8, pci_fixup_video);

arch/x86/pci/fixup.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -353,8 +353,8 @@ static void pci_fixup_video(struct pci_dev *pdev)
353353
}
354354
}
355355
}
356-
DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_ANY_ID, PCI_ANY_ID,
357-
PCI_CLASS_DISPLAY_VGA, 8, pci_fixup_video);
356+
DECLARE_PCI_FIXUP_CLASS_HEADER(PCI_ANY_ID, PCI_ANY_ID,
357+
PCI_CLASS_DISPLAY_VGA, 8, pci_fixup_video);
358358

359359

360360
static const struct dmi_system_id msi_k8t_dmi_table[] = {

drivers/pci/controller/pcie-mt7621.c

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -109,15 +109,6 @@ static inline void pcie_write(struct mt7621_pcie *pcie, u32 val, u32 reg)
109109
writel_relaxed(val, pcie->base + reg);
110110
}
111111

112-
static inline void pcie_rmw(struct mt7621_pcie *pcie, u32 reg, u32 clr, u32 set)
113-
{
114-
u32 val = readl_relaxed(pcie->base + reg);
115-
116-
val &= ~clr;
117-
val |= set;
118-
writel_relaxed(val, pcie->base + reg);
119-
}
120-
121112
static inline u32 pcie_port_read(struct mt7621_pcie_port *port, u32 reg)
122113
{
123114
return readl_relaxed(port->base + reg);
@@ -557,7 +548,7 @@ static struct platform_driver mt7621_pcie_driver = {
557548
.remove = mt7621_pcie_remove,
558549
.driver = {
559550
.name = "mt7621-pci",
560-
.of_match_table = of_match_ptr(mt7621_pcie_ids),
551+
.of_match_table = mt7621_pcie_ids,
561552
},
562553
};
563554
builtin_platform_driver(mt7621_pcie_driver);

0 commit comments

Comments
 (0)