Skip to content

Commit f8f6224

Browse files
committed
mtd: spi-nor: winbond: add "w/ and w/o SFDP" comment
Commit d35df77 ("mtd: spi-nor: winbond: fix w25q128 regression") upstream fixed a regression for flavors of 0xef4018 flash that don't define SFDP tables. Add a comment on the flash definition highlighting that there are flavors of flashes with and without SFDP support. It spares developers searching the entire git log for when we'll better handle these cases. Acked-by: Pratyush Yadav <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Tudor Ambarus <[email protected]>
1 parent b61c35e commit f8f6224

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/mtd/spi-nor/winbond.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ static const struct flash_info winbond_nor_parts[] = {
129129
.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
130130
}, {
131131
.id = SNOR_ID(0xef, 0x40, 0x18),
132+
/* Flavors w/ and w/o SFDP. */
132133
.name = "w25q128",
133134
.size = SZ_16M,
134135
.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB,

0 commit comments

Comments
 (0)