Skip to content

Commit f9af873

Browse files
XidianGeneraljgunthorpe
authored andcommitted
infiniband: i40iw: Replace GFP_ATOMIC with GFP_KERNEL in i40iw_make_listen_node
i40iw_make_listen_node() is never called in atomic context. i40iw_make_listen_node() is only called by i40iw_create_listen, which is set as ".create_listen" in struct iw_cm_verbs. Despite never getting called from atomic context, i40iw_make_listen_node() calls kzalloc() with GFP_ATOMIC, which does not sleep for allocation. GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, which can sleep and improve the possibility of sucessful allocation. This is found by a static analysis tool named DCNS written by myself. And I also manually check it. Signed-off-by: Jia-Ju Bai <[email protected]> Acked-by: Shiraz Saleem <[email protected]> Signed-off-by: Jason Gunthorpe <[email protected]>
1 parent 39e487f commit f9af873

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/infiniband/hw/i40iw/i40iw_cm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2872,7 +2872,7 @@ static struct i40iw_cm_listener *i40iw_make_listen_node(
28722872

28732873
if (!listener) {
28742874
/* create a CM listen node (1/2 node to compare incoming traffic to) */
2875-
listener = kzalloc(sizeof(*listener), GFP_ATOMIC);
2875+
listener = kzalloc(sizeof(*listener), GFP_KERNEL);
28762876
if (!listener)
28772877
return NULL;
28782878
cm_core->stats_listen_nodes_created++;

0 commit comments

Comments
 (0)