Skip to content

Commit fa0cd90

Browse files
leitaoPaolo Abeni
authored andcommitted
net: sit: Do not set .ndo_get_stats64
If the driver is using the network core allocation mechanism, by setting NETDEV_PCPU_STAT_TSTATS, as this driver is, then, it doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 function pointer. Since the network core calls it automatically, and .ndo_get_stats64 should only be set if the driver needs special treatment. This simplifies the driver, since all the generic statistics is now handled by core. Signed-off-by: Breno Leitao <[email protected]> Reviewed-by: Simon Horman <[email protected]> Signed-off-by: Paolo Abeni <[email protected]>
1 parent 3e2f544 commit fa0cd90

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

net/ipv6/sit.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1398,7 +1398,6 @@ static const struct net_device_ops ipip6_netdev_ops = {
13981398
.ndo_uninit = ipip6_tunnel_uninit,
13991399
.ndo_start_xmit = sit_tunnel_xmit,
14001400
.ndo_siocdevprivate = ipip6_tunnel_siocdevprivate,
1401-
.ndo_get_stats64 = dev_get_tstats64,
14021401
.ndo_get_iflink = ip_tunnel_get_iflink,
14031402
.ndo_tunnel_ctl = ipip6_tunnel_ctl,
14041403
};

0 commit comments

Comments
 (0)