Skip to content

Commit fa3a03d

Browse files
ecsvsimonwunderlich
authored andcommitted
batman-adv: Fix netlink dumping of all mcast_flags buckets
The bucket variable is only updated outside the loop over the mcast_flags buckets. It will only be updated during a dumping run when the dumping has to be interrupted and a new message has to be started. This could result in repeated or missing entries when the multicast flags are dumped to userspace. Fixes: d2d489b ("batman-adv: Add inconsistent multicast netlink dump detection") Signed-off-by: Sven Eckelmann <[email protected]> Signed-off-by: Simon Wunderlich <[email protected]>
1 parent 5f9e832 commit fa3a03d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/batman-adv/multicast.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2303,7 +2303,7 @@ __batadv_mcast_flags_dump(struct sk_buff *msg, u32 portid,
23032303

23042304
while (bucket_tmp < hash->size) {
23052305
if (batadv_mcast_flags_dump_bucket(msg, portid, cb, hash,
2306-
*bucket, &idx_tmp))
2306+
bucket_tmp, &idx_tmp))
23072307
break;
23082308

23092309
bucket_tmp++;

0 commit comments

Comments
 (0)