Skip to content

Commit fb23403

Browse files
lxindavem330
authored andcommitted
sctp: remove the useless check in sctp_renege_events
Remove the 'if (chunk)' check in sctp_renege_events for idata process, as all renege commands are generated in sctp_eat_data and it can't be NULL. The same thing we already did for common data in sctp_ulpq_renege. Fixes: 94014e8 ("sctp: implement renege_events for sctp_stream_interleave") Signed-off-by: Xin Long <[email protected]> Acked-by: Marcelo Ricardo Leitner <[email protected]> Acked-by: Neil Horman <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 947820b commit fb23403

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

net/sctp/stream_interleave.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -954,12 +954,8 @@ static void sctp_renege_events(struct sctp_ulpq *ulpq, struct sctp_chunk *chunk,
954954
__u32 freed = 0;
955955
__u16 needed;
956956

957-
if (chunk) {
958-
needed = ntohs(chunk->chunk_hdr->length);
959-
needed -= sizeof(struct sctp_idata_chunk);
960-
} else {
961-
needed = SCTP_DEFAULT_MAXWINDOW;
962-
}
957+
needed = ntohs(chunk->chunk_hdr->length) -
958+
sizeof(struct sctp_idata_chunk);
963959

964960
if (skb_queue_empty(&asoc->base.sk->sk_receive_queue)) {
965961
freed = sctp_ulpq_renege_list(ulpq, &ulpq->lobby, needed);

0 commit comments

Comments
 (0)