Skip to content

Commit fb64de1

Browse files
julianwiedmanndavem330
authored andcommitted
s390/qeth: phase out OSN support
OSN devices currently spend an awful long time in qeth_l2_set_online() until various unsupported HW cmds time out. This has been broken for over two years, ever since commit d22ffb5 ("s390/qeth: fix IPA command submission race") triggered a FW bug in cmd processing. Prior to commit 782e4a7 ("s390/qeth: don't poll for cmd IO completion"), this wait for timeout would have even been spent busy-polling. The offending patch was picked up by stable and all relevant distros, and yet noone noticed. OSN setups only ever worked in combination with an out-of-tree blob, and the last machine that even offered HW with OSN support was released back in 2015. Rather than attempting to work-around this FW issue for no actual gain, add a deprecation warning so anyone who still wants to maintain this part of the code can speak up. Else rip it all out in 2021. Signed-off-by: Julian Wiedmann <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 4e2b5aa commit fb64de1

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

drivers/s390/net/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ config QETH_OSN
9797
depends on QETH
9898
help
9999
This enables the qeth driver to support devices in OSN mode.
100+
This feature will be removed in 2021.
100101
If unsure, choose N.
101102

102103
config QETH_OSX

drivers/s390/net/qeth_l2_main.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -587,6 +587,9 @@ static int qeth_l2_probe_device(struct ccwgroup_device *gdev)
587587
struct qeth_card *card = dev_get_drvdata(&gdev->dev);
588588
int rc;
589589

590+
if (IS_OSN(card))
591+
dev_notice(&gdev->dev, "OSN support will be dropped in 2021\n");
592+
590593
qeth_l2_vnicc_set_defaults(card);
591594
mutex_init(&card->sbp_lock);
592595

0 commit comments

Comments
 (0)