Skip to content

Commit fded5fc

Browse files
cdleonardrafaeljw
authored andcommitted
cpufreq: imx6q: Fix imx6sx low frequency support
This patch contains the minimal changes required to support imx6sx OPP of 198 Mhz. Without this patch cpufreq still reports success but the frequency is not changed, the "arm" clock will still be at 396000000 in clk_summary. In order to do this PLL1 needs to be still kept enabled while changing the ARM clock. This is a hardware requirement: when ARM_PODF is changed in CCM we need to check the busy bit of CCM_CDHIPR bit 16 arm_podf_busy, and this bit is sync with PLL1 clock, so if PLL1 NOT enabled, this bit will never get clear. Keep pll1_sys explicitly enabled until after the rate is change to deal with this. Otherwise from the clk framework perspective pll1_sys is unused and gets turned off. Signed-off-by: Leonard Crestez <[email protected]> Reviewed-by: Lucas Stach <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 843791b commit fded5fc

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

drivers/cpufreq/imx6q-cpufreq.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ static int imx6q_set_target(struct cpufreq_policy *policy, unsigned int index)
4747
struct dev_pm_opp *opp;
4848
unsigned long freq_hz, volt, volt_old;
4949
unsigned int old_freq, new_freq;
50+
bool pll1_sys_temp_enabled = false;
5051
int ret;
5152

5253
new_freq = freq_table[index].frequency;
@@ -124,6 +125,10 @@ static int imx6q_set_target(struct cpufreq_policy *policy, unsigned int index)
124125
if (freq_hz > clk_get_rate(pll2_pfd2_396m_clk)) {
125126
clk_set_rate(pll1_sys_clk, new_freq * 1000);
126127
clk_set_parent(pll1_sw_clk, pll1_sys_clk);
128+
} else {
129+
/* pll1_sys needs to be enabled for divider rate change to work. */
130+
pll1_sys_temp_enabled = true;
131+
clk_prepare_enable(pll1_sys_clk);
127132
}
128133
}
129134

@@ -135,6 +140,10 @@ static int imx6q_set_target(struct cpufreq_policy *policy, unsigned int index)
135140
return ret;
136141
}
137142

143+
/* PLL1 is only needed until after ARM-PODF is set. */
144+
if (pll1_sys_temp_enabled)
145+
clk_disable_unprepare(pll1_sys_clk);
146+
138147
/* scaling down? scale voltage after frequency */
139148
if (new_freq < old_freq) {
140149
ret = regulator_set_voltage_tol(arm_reg, volt, 0);

0 commit comments

Comments
 (0)