Skip to content

Commit fe578cb

Browse files
elic307iSaeed Mahameed
authored andcommitted
net/mlx5: Move devlink registration before mlx5_load
In order to allow reference to devlink parameters during driver load, move the devlink registration before mlx5_load. Subsequent patch will use it to control the number of completion vectors required based on whether eth is enabled or not. Signed-off-by: Eli Cohen <[email protected]> Reviewed-by: Shay Drory <[email protected]> Signed-off-by: Saeed Mahameed <[email protected]> Reviewed-by: Jacob Keller <[email protected]>
1 parent 3354822 commit fe578cb

File tree

1 file changed

+7
-7
lines changed
  • drivers/net/ethernet/mellanox/mlx5/core

1 file changed

+7
-7
lines changed

drivers/net/ethernet/mellanox/mlx5/core/main.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1399,16 +1399,16 @@ int mlx5_init_one(struct mlx5_core_dev *dev)
13991399
goto function_teardown;
14001400
}
14011401

1402+
err = mlx5_devlink_params_register(priv_to_devlink(dev));
1403+
if (err)
1404+
goto err_devlink_params_reg;
1405+
14021406
err = mlx5_load(dev);
14031407
if (err)
14041408
goto err_load;
14051409

14061410
set_bit(MLX5_INTERFACE_STATE_UP, &dev->intf_state);
14071411

1408-
err = mlx5_devlink_params_register(priv_to_devlink(dev));
1409-
if (err)
1410-
goto err_devlink_params_reg;
1411-
14121412
err = mlx5_register_device(dev);
14131413
if (err)
14141414
goto err_register;
@@ -1418,11 +1418,11 @@ int mlx5_init_one(struct mlx5_core_dev *dev)
14181418
return 0;
14191419

14201420
err_register:
1421-
mlx5_devlink_params_unregister(priv_to_devlink(dev));
1422-
err_devlink_params_reg:
14231421
clear_bit(MLX5_INTERFACE_STATE_UP, &dev->intf_state);
14241422
mlx5_unload(dev);
14251423
err_load:
1424+
mlx5_devlink_params_unregister(priv_to_devlink(dev));
1425+
err_devlink_params_reg:
14261426
mlx5_cleanup_once(dev);
14271427
function_teardown:
14281428
mlx5_function_teardown(dev, true);
@@ -1441,7 +1441,6 @@ void mlx5_uninit_one(struct mlx5_core_dev *dev)
14411441
mutex_lock(&dev->intf_state_mutex);
14421442

14431443
mlx5_unregister_device(dev);
1444-
mlx5_devlink_params_unregister(priv_to_devlink(dev));
14451444

14461445
if (!test_bit(MLX5_INTERFACE_STATE_UP, &dev->intf_state)) {
14471446
mlx5_core_warn(dev, "%s: interface is down, NOP\n",
@@ -1452,6 +1451,7 @@ void mlx5_uninit_one(struct mlx5_core_dev *dev)
14521451

14531452
clear_bit(MLX5_INTERFACE_STATE_UP, &dev->intf_state);
14541453
mlx5_unload(dev);
1454+
mlx5_devlink_params_unregister(priv_to_devlink(dev));
14551455
mlx5_cleanup_once(dev);
14561456
mlx5_function_teardown(dev, true);
14571457
out:

0 commit comments

Comments
 (0)