bnxt_en: Fix possible memory leak in bnxt_rdma_aux_device_init()

[ Upstream commit 7ac10c7 ]

If ulp = kzalloc() fails, the allocated edev will leak because it is
not properly assigned and the cleanup path will not be able to free it.
Fix it by assigning it properly immediately after allocation.

Fixes: 3034322 ("bnxt_en: Remove runtime interrupt vector allocation")
Reviewed-by: Andy Gospodarek <[email protected]>
Signed-off-by: Vikas Gupta <[email protected]>
Signed-off-by: Michael Chan <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
(cherry picked from commit c60ed825530b8c0cc2b524efd39b1d696ec54004)

Orabug: 37070270
CVE: CVE-2024-35972

Signed-off-by: Saeed Mirzamohammadi <[email protected]>
Reviewed-by: Harshit Mogalapalli <[email protected]>
Signed-off-by: Vijayendra Suman <[email protected]>

Author: vikasbrcm

drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c

@@ -392,12 +392,13 @@ void bnxt_rdma_aux_device_init(struct bnxt *bp)
 	if (!edev)
 		goto aux_dev_uninit;
 
+	aux_priv->edev = edev;
+
 	ulp = kzalloc(sizeof(*ulp), GFP_KERNEL);
 	if (!ulp)
 		goto aux_dev_uninit;
 
 	edev->ulp_tbl = ulp;
-	aux_priv->edev = edev;
 	bp->edev = edev;
 	bnxt_set_edev_info(edev, bp);